From: "Wu X.C." <bobwxc@email.cn>
To: Yanteng Si <siyanteng@loongson.cn>
Cc: Jonathan Corbet <corbet@lwn.net>, Alex Shi <alexs@kernel.org>,
Alex Shi <alex.shi@linux.alibaba.com>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Harry Wei <harryxiyou@gmail.com>,
linux-doc@vger.kernel.org, realpuyuwang@gmail.com,
siyanteng01@gmail.com
Subject: Re: [PATCH v2 2/8] docs/zh_CN: add cpu-freq cpu-drivers.rst translation
Date: Mon, 29 Mar 2021 14:21:39 +0800 [thread overview]
Message-ID: <20210329062139.GA8845@mipc> (raw)
In-Reply-To: <20210329025144.9776-3-siyanteng@loongson.cn>
Hi,
On Mon, Mar 29, 2021 at 10:51:38AM +0800, Yanteng Si wrote:
> This patch translates Documention/cpu-freq/cpu-drivers.rst into Chinese.
>
> Signed-off-by: Yanteng Si <siyanteng@loongson.cn>
> ---
> .../zh_CN/cpu-freq/cpu-drivers.rst | 259 ++++++++++++++++++
> 1 file changed, 259 insertions(+)
> create mode 100644 Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst
>
> diff --git a/Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst b/Documentation/translations/zh_CN/cpu-freq/cpu-drivers.rst
[...]
> +1.5. target/target_index
> +------------------------
> +
> +target_index调用有两个参数/:``struct cpufreq_policy * policy``和``unsigned int``
"s/。/:/" means use ':' to replace '。' ;
aka "s/{0}/{1}/" means use {1} to replace {0}, this is a sed command.
So, please delete the '/' .
[...]
> +
> +如果你需要在driver_freq_table中处理pos的位置,不要减去指针,因为它的代价相当高。相反,使用宏
> + cpufreq_for_each_entry_idx() 和 cpufreq_for_each_valid_entry_idx() 。
The spaces in the begin are also redundant.
And one more thing:
The numbers of columns are very random, if someone read the rst files
<http://fars.ee/sqoL.png>
instead of html files, that may cause difficulties. Please use a
monospaced font to fix the problem, try to keep in 74-80 columns
except meet a long English word, one Chinese character use 2 columns.
This comment is for all patches.
Thanks!
Wu X.C.
next prev parent reply other threads:[~2021-03-29 6:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 2:51 [PATCH v2 0/8] docs/zh_CN: add cpu-freq translation Yanteng Si
2021-03-29 2:51 ` [PATCH v2 1/8] docs/zh_CN: add cpu-freq core.rst translation Yanteng Si
2021-03-29 2:51 ` [PATCH v2 2/8] docs/zh_CN: add cpu-freq cpu-drivers.rst translation Yanteng Si
2021-03-29 6:21 ` Wu X.C. [this message]
2021-03-29 12:05 ` yanteng si
2021-03-29 2:51 ` [PATCH v2 3/8] docs/zh_CN: add cpu-freq cpufreq-stats.rst translation Yanteng Si
2021-03-29 6:23 ` Wu X.C.
2021-03-29 12:19 ` yanteng si
2021-03-29 13:13 ` Wu X.C.
2021-04-01 4:48 ` Alex Shi
2021-03-29 2:51 ` [PATCH v2 4/8] docs/zh_CN: add cpu-freq index.rst translation Yanteng Si
2021-03-29 2:51 ` [PATCH v2 5/8] docs/zh_CN: add cpu-freq to zh_CN index Yanteng Si
2021-03-29 2:51 ` [PATCH v2 6/8] docs/zh_CN: add mips " Yanteng Si
2021-03-29 2:51 ` [PATCH v2 7/8] docs/zh_CN: add iio " Yanteng Si
2021-03-29 2:51 ` [PATCH v2 8/8] docs/zh_CN: add riscv " Yanteng Si
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329062139.GA8845@mipc \
--to=bobwxc@email.cn \
--cc=alex.shi@linux.alibaba.com \
--cc=alexs@kernel.org \
--cc=chenhuacai@gmail.com \
--cc=corbet@lwn.net \
--cc=harryxiyou@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-doc@vger.kernel.org \
--cc=realpuyuwang@gmail.com \
--cc=siyanteng01@gmail.com \
--cc=siyanteng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).