From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 734C5C433ED for ; Thu, 15 Apr 2021 12:11:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 311406105A for ; Thu, 15 Apr 2021 12:11:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232253AbhDOMLz (ORCPT ); Thu, 15 Apr 2021 08:11:55 -0400 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:59125 "EHLO new4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231590AbhDOMLz (ORCPT ); Thu, 15 Apr 2021 08:11:55 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id D2331580469; Thu, 15 Apr 2021 08:11:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 15 Apr 2021 08:11:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= from:date:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=dX5QOHJeT8EEYEsli9LNovkUhHN 4fOmsf3zMtqEQtec=; b=Ok4tJWKQ9nH8zLd4MJuIn8JoMxqkK78wmL3ovzH/zrT UC5RfGaTG3O/7jnBmnzZW1YRWZyfmY6JqvwgwJbZcdIZY7nnoF3AArxyze5uIOBU yisRUv9h3iwLYN9cdLG3hrAoXI9tEl74msQoXbXjoxWpnhFZuW76y8xAcGzbTnIA DpDIv5d7++OUezQ7qdh0HM6gJ6kxrQJNldI2zLF4gLdXSHz9hHKcv7Skc4mgq//5 pPnBwFl5NM/+mcRmxDNuspIpkiZ00AAFYlJxHpTEbs2Kz/8uYX5C/sP6sojM413x jfJF9RzGjzBhD2Y6sM4vlAAmRvc2BKwfwWn6C8ixmUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=dX5QOH JeT8EEYEsli9LNovkUhHN4fOmsf3zMtqEQtec=; b=bms9l/dFZgiKBOhOIiLn/2 waI/WneVLkb/8OafKSeirjCnL95n9gUZfG6f7XO+ty507W2rHXt88WuH8JVqB51M fGT58YMPudQKpsbXfrztt8SoHiZlHy5rHSmCqXbfiVg9dYWsiQpT/GI2F8L4j0ae s8ad2IPWQKbJqn7f8tepsu7s9DlxS9aKkIFuFosn/yZTqdlj5W3H9BhryK8JKKVw YqbhrYfNw0+mudk+MDRBqU+tWt17Ew1fnjQ3Zb5U8DfdvSCvMb3b7eboPoMYy9Bf gJ9/AcfiQhQff0HyltA2qxIz0dVA+IU96vp8wzUNz2DLNMpsTwkRYN5LjyF4zWew == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelfedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephfffvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpehmrgigihhm vgestggvrhhnohdrthgvtghhnecuggftrfgrthhtvghrnhephffffffgteejgeeiteelue dvkeffudekjeejheevleekgffggfekkedvhfeigefgnecukfhppeeltddrkeelrdeikedr jeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA id B95F3240057; Thu, 15 Apr 2021 08:11:29 -0400 (EDT) From: maxime@cerno.tech Date: Thu, 15 Apr 2021 14:11:27 +0200 To: Thomas Zimmermann Cc: daniel@ffwll.ch, airlied@linux.ie, maarten.lankhorst@linux.intel.com, kraxel@redhat.com, corbet@lwn.net, lgirdwood@gmail.com, broonie@kernel.org, sam@ravnborg.org, robh@kernel.org, emil.l.velikov@gmail.com, geert+renesas@glider.be, hdegoede@redhat.com, bluescreen_avenger@verizon.net, dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH v2 08/10] drm/simpledrm: Acquire clocks from DT device node Message-ID: <20210415121127.igpedvc6sep5jqq5@gilmour> 65;6203;1cFrom: Maxime Ripard References: <20210318102921.21536-1-tzimmermann@suse.de> <20210318102921.21536-9-tzimmermann@suse.de> <20210408081353.ojt2kgnnbh6kp6gp@gilmour> <3c7bacd1-e40e-0953-9ad9-9f79274106d5@suse.de> <20210415092123.7zn6fbnkuqlajord@gilmour> <9b21042c-9908-3847-702a-cb891d1769e0@suse.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xpknipqqoxatjl7s" Content-Disposition: inline In-Reply-To: <9b21042c-9908-3847-702a-cb891d1769e0@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org --xpknipqqoxatjl7s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 15, 2021 at 01:02:44PM +0200, Thomas Zimmermann wrote: > Hi >=20 > Am 15.04.21 um 11:21 schrieb Maxime Ripard: > > Hi, > >=20 > > On Thu, Apr 15, 2021 at 09:31:01AM +0200, Thomas Zimmermann wrote: > > > Am 08.04.21 um 10:13 schrieb Maxime Ripard: > > > > Hi, > > > >=20 > > > > On Thu, Mar 18, 2021 at 11:29:19AM +0100, Thomas Zimmermann wrote: > > > > > Make sure required hardware clocks are enabled while the firmware > > > > > framebuffer is in use. > > > > >=20 > > > > > The basic code has been taken from the simplefb driver and adapted > > > > > to DRM. Clocks are released automatically via devres helpers. > > > > >=20 > > > > > Signed-off-by: Thomas Zimmermann > > > > > Tested-by: nerdopolis > > > >=20 > > > > Even though it's definitely simpler to review, merging the driver f= irst > > > > and then the clocks and regulators will break bisection on the plat= forms > > > > that rely on them > > >=20 > > > I'd like to keep the patches separate for now, but can squash patches= 6 to 8 > > > them into one before pushing them. OK? > >=20 > > Yep, that works for me :) > >=20 > > > >=20 > > > > Another thing worth considering is also that both drivers will prob= e if > > > > they are enabled (which is pretty likely), which is not great :) > > > >=20 > > > > I guess we should make them mutually exclusive through Kconfig > > >=20 > > > We already have several drivers in fbdev and DRM that handle the same > > > hardware. We don't do this for any other pair, why bother now? > >=20 > > Yeah, but simplefb/simpledrm are going to be enabled pretty much > > everywhere, as opposed to the other drivers that are more specialized. >=20 > Well, OK. But I'd like to give simpledrm preference over simplefb. There > should be an incentive to switch to DRM. Yeah that makes total sense :) Maxime --xpknipqqoxatjl7s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYHgtbwAKCRDj7w1vZxhR xXyxAQD+qBPDs5S8cLtsrSgQ8fpCjtSaiJZxGR5K8NPf4htoKQD9HGpx3iW6o2Y9 kRc9WTYIck5gl3qzTWqLhoat+5tLbQg= =H9L5 -----END PGP SIGNATURE----- --xpknipqqoxatjl7s--