From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E0AC48BDF for ; Sat, 19 Jun 2021 02:45:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2708D6120D for ; Sat, 19 Jun 2021 02:45:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235035AbhFSCr7 (ORCPT ); Fri, 18 Jun 2021 22:47:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234448AbhFSCr7 (ORCPT ); Fri, 18 Jun 2021 22:47:59 -0400 Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 10BEAC06175F for ; Fri, 18 Jun 2021 19:45:48 -0700 (PDT) Received: by mail-pf1-x42a.google.com with SMTP id h12so9175266pfe.2 for ; Fri, 18 Jun 2021 19:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zAYV7wMM7Ezv8dDkbAjr47uPXYKTsdhdBtQn9j9OFnQ=; b=Q2OJ2V/f8FZEH317J3bz6jJZxIGjbRaNkKQIRx821VhRbFsIHrPq+Zay4VGnDoiem3 h5LzzP3EtTb95X3yOnHsnK0DXz+ppJPbmxOjwonoz6Vp5YBhvZqOmANEITrlb7cwBX66 OHR4Cr7BDqNiJ6hJrDmkmpm82iFxhnS7Uk1do= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zAYV7wMM7Ezv8dDkbAjr47uPXYKTsdhdBtQn9j9OFnQ=; b=skfnZctvct677RDVWqKknTRKd/EKo6uVP3IG9B6d2qwVeAV2+PNbfiVgCAbawapGi7 j24+MZycC22jTKPgidNtN9hKNLCV8CirRzTYbuzKn/4mhQnFkdGlNqLRoA8P3keqS9eh dvX52+1alP634nu2A7K/UKCFb+TQ3/cYbCXlhCG9hXggE/Bz3kwl7yuLizrpiVpKpjLf U4XryDiqIUnlJTHaxH3BYW6iHz2iGXeCFR4DB2LjbKKnwF2z62EnAyaecj/dZdrNslt0 YARURkZyOLGAmlShxsvAb+shcOzGrKgbk6hnIw7zMQ/9tBOoX3VWwFrJDANYCGMw2EDJ YzBg== X-Gm-Message-State: AOAM533M+iNREPjIc/K0VncY4NgZIxLqQhEWB9cxeFoglaBSIxTP0E2I cNenIb4qLbPEdhKegrE1T00+gg== X-Google-Smtp-Source: ABdhPJweZiwRILILciRX6LD55JeoGO8LssAH/WdscRnLKM2PzFFoKdbgNhnxUUkHKzp2FHsJS7btNw== X-Received: by 2002:a62:6581:0:b029:2ef:bcb1:c406 with SMTP id z123-20020a6265810000b02902efbcb1c406mr8009133pfb.28.1624070747426; Fri, 18 Jun 2021 19:45:47 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id h21sm8559917pfv.190.2021.06.18.19.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 19:45:46 -0700 (PDT) Date: Fri, 18 Jun 2021 19:45:45 -0700 From: Kees Cook To: Nick Desaulniers Cc: Peter Zijlstra , Bill Wendling , Sami Tolvanen , Peter Oberparleiter , Masahiro Yamada , Miguel Ojeda , Nathan Chancellor , Luc Van Oostenryck , Ard Biesheuvel , Will Deacon , Arnd Bergmann , Andrew Morton , Rasmus Villemoes , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, x86@kernel.org, Borislav Petkov , Martin Liska , Marco Elver , Jonathan Corbet , Fangrui Song , linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, Dmitry Vyukov , johannes.berg@intel.com, linux-toolchains@vger.kernel.org Subject: Re: [PATCH 0/2] no_profile fn attr and Kconfig for GCOV+PGO Message-ID: <202106181945.AC10BF38ED@keescook> References: <20210618233023.1360185-1-ndesaulniers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210618233023.1360185-1-ndesaulniers@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Jun 18, 2021 at 04:30:21PM -0700, Nick Desaulniers wrote: > When we say noinstr, we mean noinstr. GCOV and PGO can both instrument > functions. Add a new function annotation __no_profile that expands to > __attribute__((__no_profile__)) and Kconfig value > CC_HAS_NO_PROFILE_FN_ATTR. > > Base is > https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/clang/pgo. > > Nick Desaulniers (2): > compiler_attributes.h: define __no_profile, add to noinstr > Kconfig: CC_HAS_NO_PROFILE_FN_ATTR, depend on for GCOV and PGO Oh, awesome! Thanks for the fast work on this. If there are no objections, I'll apply this in front of the PGO series and put it in -next. -Kees > > include/linux/compiler_attributes.h | 12 ++++++++++++ > include/linux/compiler_types.h | 2 +- > init/Kconfig | 3 +++ > kernel/gcov/Kconfig | 1 + > kernel/pgo/Kconfig | 3 ++- > 5 files changed, 19 insertions(+), 2 deletions(-) > > > base-commit: 4356bc4c0425c81e204f561acf4dd0095544a6cb > -- > 2.32.0.288.g62a8d224e6-goog > -- Kees Cook