From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8130C48BE5 for ; Mon, 21 Jun 2021 08:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B57D1611BD for ; Mon, 21 Jun 2021 08:32:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230268AbhFUIeN (ORCPT ); Mon, 21 Jun 2021 04:34:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230415AbhFUIeA (ORCPT ); Mon, 21 Jun 2021 04:34:00 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2289FC061767; Mon, 21 Jun 2021 01:31:46 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id f70so28270562qke.13; Mon, 21 Jun 2021 01:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=27fs4ayWfwDx66gepojtp7zAr2zH3uKkjECbTbsrrQM=; b=W5cSoZPWgKoDTsIoHK7Z2ydoJXNZNDaY8ysBq3Ght6vISwdF4nVdZ82SaPeM7Tw/CO TObpiwn7OdxAVdixVn47w7wabaEfor/rD7fejPfUSpGa9oLHN5VV5KJtNKZ+TBwGoEJO cCos1IwctUqvREkRh3LLoK9/Xlb39RQSJVA8UfJut3nfLoUst1P4cLVqC7+BKQzXuVsx jjHfXdNYEghy9Pg1Lk2S7MMOFkxedbEdzYp9EdRPOyanmc3eIIi5bf3YNFfkbOQ6qxp7 83coXN50H8tK2xKwmu0dQkrFb8vTE8JFEYC2dkI349Dj0QZ0KkTguaKlG+hOXxL+YDcE yHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=27fs4ayWfwDx66gepojtp7zAr2zH3uKkjECbTbsrrQM=; b=Tw9zlghNP2lMtvkjF+jXIw8cIb9CfadeHddyDj+bDlp8L1NR56Vu8Q1QXv/6RYZRnZ skAjWuFY3G7KJVz0bbQhoZRB/APyVzT4NLrhUXkyaY9S3kvICJV9GfE9G7w7AqFECAGd AUJdC6+nmLLmlcdFhDKpnVLwDl7RoT9LPxBzATX8tmg8DSBiO5r2YSV1fBXSbbIGFROA 5YIc2MsLz2PDY/jBkLYERKNBfTuon+dXhygu6BzfYfa0j41EQQ1dwBZmKMU3zZRTpCoP ogr2KyJSZdXQFtVgGNwTHRu/bSYHfcCYqI0xP2BRtKkNa6Jz498kfgEhiseBoTpiDiT6 0wlA== X-Gm-Message-State: AOAM531DUBFbQVhkm4fOPzeoC5Q7PKpGI/h7PlqN5+gmkXlvw5k9qkak /kFEBK/u9TSlNhWe8WQiWSA= X-Google-Smtp-Source: ABdhPJxfpfFM8Nu58EU59s2qXHapzK9iuOSF5DgEk5v33gbk4tr/z6XCCU6zFRs1bjTXJE+jEKDoZg== X-Received: by 2002:a37:7d83:: with SMTP id y125mr22320768qkc.7.1624264305350; Mon, 21 Jun 2021 01:31:45 -0700 (PDT) Received: from localhost.localdomain (ec2-35-169-212-159.compute-1.amazonaws.com. [35.169.212.159]) by smtp.gmail.com with ESMTPSA id l23sm9852581qtp.28.2021.06.21.01.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 01:31:44 -0700 (PDT) From: SeongJae Park To: akpm@linux-foundation.org Cc: SeongJae Park , Jonathan.Cameron@Huawei.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendanhiggins@google.com, corbet@lwn.net, david@redhat.com, dwmw@amazon.com, elver@google.com, fan.du@intel.com, foersleo@amazon.de, greg@kroah.com, gthelen@google.com, guoju.fgj@alibaba-inc.com, jgowans@amazon.com, mgorman@suse.de, mheyne@amazon.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, rppt@kernel.org, shakeelb@google.com, shuah@kernel.org, sieberf@amazon.com, sj38.park@gmail.com, snu@zelle79.org, vbabka@suse.cz, vdavydov.dev@gmail.com, zgf574564920@gmail.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v31 08/13] mm/damon/dbgfs: Export kdamond pid to the user space Date: Mon, 21 Jun 2021 08:31:03 +0000 Message-Id: <20210621083108.17589-9-sj38.park@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210621083108.17589-1-sj38.park@gmail.com> References: <20210621083108.17589-1-sj38.park@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org From: SeongJae Park For CPU usage accounting, knowing pid of the monitoring thread could be helpful. For example, users could use cpuaccount cgroups with the pid. This commit therefore exports the pid of currently running monitoring thread to the user space via 'kdamond_pid' file in the debugfs directory. Signed-off-by: SeongJae Park Reviewed-by: Fernand Sieber --- mm/damon/dbgfs.c | 38 ++++++++++++++++++++++++++++++++++++-- 1 file changed, 36 insertions(+), 2 deletions(-) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index c4a4a6f1dc79..524362f8c628 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -237,6 +237,32 @@ static ssize_t dbgfs_target_ids_write(struct file *file, return ret; } +static ssize_t dbgfs_kdamond_pid_read(struct file *file, + char __user *buf, size_t count, loff_t *ppos) +{ + struct damon_ctx *ctx = file->private_data; + char *kbuf; + ssize_t len; + + kbuf = kmalloc(count, GFP_KERNEL); + if (!kbuf) + return -ENOMEM; + + mutex_lock(&ctx->kdamond_lock); + if (ctx->kdamond) + len = scnprintf(kbuf, count, "%d\n", ctx->kdamond->pid); + else + len = scnprintf(kbuf, count, "none\n"); + mutex_unlock(&ctx->kdamond_lock); + if (!len) + goto out; + len = simple_read_from_buffer(buf, count, ppos, kbuf, len); + +out: + kfree(kbuf); + return len; +} + static int damon_dbgfs_open(struct inode *inode, struct file *file) { file->private_data = inode->i_private; @@ -258,10 +284,18 @@ static const struct file_operations target_ids_fops = { .write = dbgfs_target_ids_write, }; +static const struct file_operations kdamond_pid_fops = { + .owner = THIS_MODULE, + .open = damon_dbgfs_open, + .read = dbgfs_kdamond_pid_read, +}; + static void dbgfs_fill_ctx_dir(struct dentry *dir, struct damon_ctx *ctx) { - const char * const file_names[] = {"attrs", "target_ids"}; - const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops}; + const char * const file_names[] = {"attrs", "target_ids", + "kdamond_pid"}; + const struct file_operations *fops[] = {&attrs_fops, &target_ids_fops, + &kdamond_pid_fops}; int i; for (i = 0; i < ARRAY_SIZE(file_names); i++) -- 2.17.1