From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06252C636CA for ; Sun, 18 Jul 2021 21:31:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E3A8E61026 for ; Sun, 18 Jul 2021 21:31:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233265AbhGRVeT (ORCPT ); Sun, 18 Jul 2021 17:34:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232459AbhGRVeS (ORCPT ); Sun, 18 Jul 2021 17:34:18 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E8C6C061764 for ; Sun, 18 Jul 2021 14:31:19 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id e20so23003866ljn.8 for ; Sun, 18 Jul 2021 14:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F9ILCk8N3sERVUTaY+/ZVi6bG07HT24teouMKnXfFEQ=; b=ax13dcXsQdSfOz+9HVljsgiGChow9heRlR8KjejNczxJGHDUg6gsv24iZ2QyUExZmj wQh6yUun2RAFTurk6dA0NJMkInZBtaW3QlA7diHzWjCJo+2E9x/zMtsYBpzq8Qo7SLNN 3QqLXkNULJs0Q5LBpjLIp8AmZGk3FhEGYesSLd76i6x6tuJHsj2KlVu5D6OfW/lckUuY 1zXDoFoI240WefoNiWy3RY8vfT12vc5KjxjdiAWWn7Ms30PAZ75iPsrVwfHABzH7CyWW CYtzflOrlbUO8sRAbStI3uJP2bWlBubp097D1XWgZ6WtwdZxvflRVNhAEnHD7tX5BGak f/DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F9ILCk8N3sERVUTaY+/ZVi6bG07HT24teouMKnXfFEQ=; b=ZFxfYc8h6mBYNLbGiomeqEr3cDhsVDy4lLPvRlBIZkv2868n2o8tul6MWPHbTSU/FD XIW7naOSZBMGGkwt5NTQBZ4GhXklIC6YIH0j3Qa5wGRcaM/2aI6NAC73YXcnYhajNf39 YOk6Fb3izpK9puu++djNnyz9jKzsNAlLX6L/iIAHpEc9sPWzJqi2XkSK4MLw5qYnyLeF sTf3SKbA0Xga7NqayhGghSjzHQUBRLkCLLwneqp0udGZ2TNof6iCHJZpDlyvfu+uB9ht cHgoDHgcKPw/e+efAGcdetpdo26413up+eEQr3SKy/A3Ox3PsZknmJTIHXNycOu1gEBE nuLg== X-Gm-Message-State: AOAM533KAPQQawUHRwlQ4UDLTdDAXUbUHOeA2Hy6ZiHn9j4gWQXH3HhJ ywobwP6WH8MRLzldtHHZXnHoDQ== X-Google-Smtp-Source: ABdhPJwtT5qmE/P10UDYjLKt4tr/vkQdwA/jD7zdttq+I56o4yokObToWGuF9FbR11p8WQaMKdSbqQ== X-Received: by 2002:a05:651c:158b:: with SMTP id h11mr19410663ljq.395.1626643877625; Sun, 18 Jul 2021 14:31:17 -0700 (PDT) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id r3sm1237633lfc.280.2021.07.18.14.31.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Jul 2021 14:31:16 -0700 (PDT) Received: by box.localdomain (Postfix, from userid 1000) id CB77E10260F; Mon, 19 Jul 2021 00:31:20 +0300 (+03) Date: Mon, 19 Jul 2021 00:31:20 +0300 From: "Kirill A. Shutemov" To: Qi Zheng Cc: akpm@linux-foundation.org, tglx@linutronix.de, hannes@cmpxchg.org, mhocko@kernel.org, vdavydov.dev@gmail.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com Subject: Re: [PATCH 2/7] mm: introduce pte_install() helper Message-ID: <20210718213120.rtqbgseb6drcwxj4@box.shutemov.name> References: <20210718043034.76431-1-zhengqi.arch@bytedance.com> <20210718043034.76431-3-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210718043034.76431-3-zhengqi.arch@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Sun, Jul 18, 2021 at 12:30:28PM +0800, Qi Zheng wrote: > Currently we have three times the same few lines repeated in the > code. Deduplicate them by newly introduced pte_install() helper. > > Signed-off-by: Qi Zheng I don't like the name of the helper: we have confusion of PTE being PTE-entry or PTE page table. And pte_install() doing pmd_populate() doesn't help the situation. Maybe pmd_install()? Or pte_table_install()? I donno. -- Kirill A. Shutemov