From: Andrew Morton <akpm@linux-foundation.org>
To: Charan Teja Kalla <charante@codeaurora.org>
Cc: Mike Rapoport <rppt@kernel.org>,
mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com,
dave.hansen@linux.intel.com, vbabka@suse.cz,
mgorman@techsingularity.net, nigupta@nvidia.com, corbet@lwn.net,
khalid.aziz@oracle.com, rientjes@google.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
vinmenon@codeaurora.org
Subject: Re: [PATCH V5] mm: compaction: support triggering of proactive compaction by user
Date: Mon, 2 Aug 2021 13:41:41 -0700 [thread overview]
Message-ID: <20210802134141.dbff2d5f850bbe84f3bef4d5@linux-foundation.org> (raw)
In-Reply-To: <1089d373-221e-7094-b778-ac260ca139a5@codeaurora.org>
On Mon, 2 Aug 2021 17:30:16 +0530 Charan Teja Kalla <charante@codeaurora.org> wrote:
> Thanks Mike for the review!!
>
> On 7/31/2021 1:01 AM, Mike Rapoport wrote:
> >> diff --git a/Documentation/admin-guide/sysctl/vm.rst b/Documentation/admin-guide/sysctl/vm.rst
> >> index 003d5cc..b526cf6 100644
> >> --- a/Documentation/admin-guide/sysctl/vm.rst
> >> +++ b/Documentation/admin-guide/sysctl/vm.rst
> >> @@ -118,7 +118,8 @@ compaction_proactiveness
> >>
> >> This tunable takes a value in the range [0, 100] with a default value of
> >> 20. This tunable determines how aggressively compaction is done in the
> >> -background. Setting it to 0 disables proactive compaction.
> >> +background. On write of non zero value to this tunable will immediately
> > Nit: I think "Write of non zero ..."
>
> Can Andrew change it while applying the patch ?
I have done so, thanks.
next prev parent reply other threads:[~2021-08-02 20:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 13:53 [PATCH V5] mm: compaction: support triggering of proactive compaction by user Charan Teja Reddy
2021-07-30 14:06 ` Vlastimil Babka
2021-07-30 14:46 ` Charan Teja Kalla
2021-07-30 14:47 ` Vlastimil Babka
2021-07-30 19:31 ` Mike Rapoport
2021-08-02 12:00 ` Charan Teja Kalla
2021-08-02 20:41 ` Andrew Morton [this message]
2021-08-04 21:11 ` Rafael Aquini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802134141.dbff2d5f850bbe84f3bef4d5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=charante@codeaurora.org \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=khalid.aziz@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=nigupta@nvidia.com \
--cc=rientjes@google.com \
--cc=rppt@kernel.org \
--cc=vbabka@suse.cz \
--cc=vinmenon@codeaurora.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).