From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Eugene Syromiatnikov <esyr@redhat.com>
Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
Chris Hyser <chris.hyser@oracle.com>,
Josh Don <joshdon@google.com>, Ingo Molnar <mingo@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
"Dmitry V. Levin" <ldv@strace.io>,
linux-doc@vger.kernel.org, linux-api@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v3] uapi: expose enum pid_type as enum __kernel_pidtype
Date: Sat, 7 Aug 2021 17:48:17 +0300 [thread overview]
Message-ID: <20210807144817.GC11597@altlinux.org> (raw)
In-Reply-To: <20210807120905.GA14706@asgard.redhat.com>
On Sat, Aug 07, 2021 at 02:09:05PM +0200, Eugene Syromiatnikov wrote:
> Commit 7ac592aa35a684ff ("sched: prctl() core-scheduling interface")
> made use of enum pid_type in prctl's arg4; however, this type
> and the associated enumeration definitions are not exposed to userspace.
> Try to fix that by providing enum __kernel_pidtype and tying in-kernel
> enum pid_type definitions to it. Note that enum pid_type cannot be exposed
> as is, since "enum pid_type" is already exists in various projects [1]
Grammar: "enum pid_type" already exists.
> (notably gcc and strace), and "enum __pid_type" is defined by glibc and uclibc
> for fcntl(F_SETOWN_EX) owner ID type; there is also __kernel_pid_t,
> that looks too similar to __kernel_pid_type.
>
> [1] https://codesearch.debian.net/search?q=enum+pid_type
>
> Complements: 7ac592aa35a684ff ("sched: prctl() core-scheduling interface")
> Signed-off-by: Eugene Syromiatnikov <esyr@redhat.com>
Reviewed-by: Dmitry V. Levin <ldv@altlinux.org>
--
ldv
prev parent reply other threads:[~2021-08-07 14:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-07 12:09 [PATCH v3] uapi: expose enum pid_type as enum __kernel_pidtype Eugene Syromiatnikov
2021-08-07 14:48 ` Dmitry V. Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210807144817.GC11597@altlinux.org \
--to=ldv@altlinux.org \
--cc=chris.hyser@oracle.com \
--cc=corbet@lwn.net \
--cc=esyr@redhat.com \
--cc=joel@joelfernandes.org \
--cc=joshdon@google.com \
--cc=ldv@strace.io \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).