From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26464C4320A for ; Sat, 7 Aug 2021 14:48:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 04D55610C7 for ; Sat, 7 Aug 2021 14:48:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbhHGOsh (ORCPT ); Sat, 7 Aug 2021 10:48:37 -0400 Received: from vmicros1.altlinux.org ([194.107.17.57]:55424 "EHLO vmicros1.altlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbhHGOsg (ORCPT ); Sat, 7 Aug 2021 10:48:36 -0400 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id 9291B72C8F8; Sat, 7 Aug 2021 17:48:17 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 73BE57CF71A; Sat, 7 Aug 2021 17:48:17 +0300 (MSK) Date: Sat, 7 Aug 2021 17:48:17 +0300 From: "Dmitry V. Levin" To: Eugene Syromiatnikov Cc: "Peter Zijlstra (Intel)" , "Joel Fernandes (Google)" , Chris Hyser , Josh Don , Ingo Molnar , Vincent Guittot , Valentin Schneider , Mel Gorman , linux-kernel@vger.kernel.org, Thomas Gleixner , "Dmitry V. Levin" , linux-doc@vger.kernel.org, linux-api@vger.kernel.org, Jonathan Corbet Subject: Re: [PATCH v3] uapi: expose enum pid_type as enum __kernel_pidtype Message-ID: <20210807144817.GC11597@altlinux.org> References: <20210807120905.GA14706@asgard.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210807120905.GA14706@asgard.redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Sat, Aug 07, 2021 at 02:09:05PM +0200, Eugene Syromiatnikov wrote: > Commit 7ac592aa35a684ff ("sched: prctl() core-scheduling interface") > made use of enum pid_type in prctl's arg4; however, this type > and the associated enumeration definitions are not exposed to userspace. > Try to fix that by providing enum __kernel_pidtype and tying in-kernel > enum pid_type definitions to it. Note that enum pid_type cannot be exposed > as is, since "enum pid_type" is already exists in various projects [1] Grammar: "enum pid_type" already exists. > (notably gcc and strace), and "enum __pid_type" is defined by glibc and uclibc > for fcntl(F_SETOWN_EX) owner ID type; there is also __kernel_pid_t, > that looks too similar to __kernel_pid_type. > > [1] https://codesearch.debian.net/search?q=enum+pid_type > > Complements: 7ac592aa35a684ff ("sched: prctl() core-scheduling interface") > Signed-off-by: Eugene Syromiatnikov Reviewed-by: Dmitry V. Levin -- ldv