linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Steve French <stfrench@microsoft.com>
Cc: kbuild-all@lists.01.org, linux-cifs@vger.kernel.org,
	samba-technical@lists.samba.org, linux-doc@vger.kernel.org
Subject: [cifs:for-next 1/1] fs/smbfs/connect.c:1093: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
Date: Mon, 13 Sep 2021 21:00:06 +0800	[thread overview]
Message-ID: <202109132050.ILDSqPvf-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 5598 bytes --]

Hi Steve,

First bad commit (maybe != root cause):

tree:   git://git.samba.org/sfrench/cifs-2.6.git for-next
head:   bba805a46c91e7a8a1d04704e5409f890acf8b66
commit: bba805a46c91e7a8a1d04704e5409f890acf8b66 [1/1] cifs: rename fs/cifs directory to fs/smbfs
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git remote add cifs git://git.samba.org/sfrench/cifs-2.6.git
        git fetch --no-tags cifs for-next
        git checkout bba805a46c91e7a8a1d04704e5409f890acf8b66
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> fs/smbfs/connect.c:1093: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
    * Returns true if srcaddr isn't specified and rhs isn't specified, or
   fs/smbfs/connect.c:1558: warning: Function parameter or member 'ses' not described in 'cifs_setup_ipc'
   fs/smbfs/connect.c:1558: warning: Function parameter or member 'ctx' not described in 'cifs_setup_ipc'
   fs/smbfs/connect.c:1618: warning: Function parameter or member 'ses' not described in 'cifs_free_ipc'
   fs/smbfs/connect.c:1864: warning: Function parameter or member 'server' not described in 'cifs_get_smb_ses'
   fs/smbfs/connect.c:1864: warning: Function parameter or member 'ctx' not described in 'cifs_get_smb_ses'
   fs/smbfs/connect.c:2087: warning: Function parameter or member 'ses' not described in 'cifs_get_tcon'
   fs/smbfs/connect.c:2087: warning: Function parameter or member 'ctx' not described in 'cifs_get_tcon'
   fs/smbfs/connect.c:3046: warning: Function parameter or member 'xid' not described in 'expand_dfs_referral'
   fs/smbfs/connect.c:3046: warning: Function parameter or member 'ses' not described in 'expand_dfs_referral'
   fs/smbfs/connect.c:3046: warning: Function parameter or member 'ctx' not described in 'expand_dfs_referral'
   fs/smbfs/connect.c:3046: warning: Function parameter or member 'cifs_sb' not described in 'expand_dfs_referral'
   fs/smbfs/connect.c:3046: warning: Function parameter or member 'ref_path' not described in 'expand_dfs_referral'


vim +1093 fs/smbfs/connect.c

^1da177e4c3f41 fs/cifs/connect.c Linus Torvalds     2005-04-16  1091  
bc04499477d9f0 fs/cifs/connect.c Steve French       2020-12-11  1092  /**
bc04499477d9f0 fs/cifs/connect.c Steve French       2020-12-11 @1093   * Returns true if srcaddr isn't specified and rhs isn't specified, or
bc04499477d9f0 fs/cifs/connect.c Steve French       2020-12-11  1094   * if srcaddr is specified and matches the IP address of the rhs argument
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1095   */
e4af35fa55b072 fs/cifs/connect.c Paulo Alcantara    2020-05-19  1096  bool
e4af35fa55b072 fs/cifs/connect.c Paulo Alcantara    2020-05-19  1097  cifs_match_ipaddr(struct sockaddr *srcaddr, struct sockaddr *rhs)
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1098  {
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1099  	switch (srcaddr->sa_family) {
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1100  	case AF_UNSPEC:
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1101  		return (rhs->sa_family == AF_UNSPEC);
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1102  	case AF_INET: {
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1103  		struct sockaddr_in *saddr4 = (struct sockaddr_in *)srcaddr;
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1104  		struct sockaddr_in *vaddr4 = (struct sockaddr_in *)rhs;
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1105  		return (saddr4->sin_addr.s_addr == vaddr4->sin_addr.s_addr);
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1106  	}
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1107  	case AF_INET6: {
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1108  		struct sockaddr_in6 *saddr6 = (struct sockaddr_in6 *)srcaddr;
e3e2775cedc9d6 fs/cifs/connect.c Nickolai Zeldovich 2013-01-16  1109  		struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *)rhs;
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1110  		return ipv6_addr_equal(&saddr6->sin6_addr, &vaddr6->sin6_addr);
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1111  	}
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1112  	default:
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1113  		WARN_ON(1);
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1114  		return false; /* don't expect to be here */
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1115  	}
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1116  }
3eb9a8893a76cf fs/cifs/connect.c Ben Greear         2010-09-01  1117  

:::::: The code at line 1093 was first introduced by commit
:::::: bc04499477d9f01034c2afb6097e835c705ac3bd cifs: minor kernel style fixes for comments

:::::: TO: Steve French <stfrench@microsoft.com>
:::::: CC: Steve French <stfrench@microsoft.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 55509 bytes --]

                 reply	other threads:[~2021-09-13 13:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202109132050.ILDSqPvf-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=samba-technical@lists.samba.org \
    --cc=stfrench@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).