From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCEC2C433F5 for ; Tue, 5 Oct 2021 04:12:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92B4B6140A for ; Tue, 5 Oct 2021 04:12:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229659AbhJEEOd (ORCPT ); Tue, 5 Oct 2021 00:14:33 -0400 Received: from mga11.intel.com ([192.55.52.93]:56091 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbhJEEOd (ORCPT ); Tue, 5 Oct 2021 00:14:33 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10127"; a="223063574" X-IronPort-AV: E=Sophos;i="5.85,347,1624345200"; d="scan'208";a="223063574" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 21:12:43 -0700 X-IronPort-AV: E=Sophos;i="5.85,347,1624345200"; d="scan'208";a="487837619" Received: from yilai-mobl1.ccr.corp.intel.com (HELO chenyu5-mobl1) ([10.249.172.101]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2021 21:12:37 -0700 Date: Tue, 5 Oct 2021 12:12:31 +0800 From: Chen Yu To: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman , ACPI Devel Maling List , Linux Kernel Mailing List , Len Brown , Dan Williams , Andy Shevchenko , Aubrey Li , Ashok Raj , Mike Rapoport , Ard Biesheuvel , Jonathan Corbet , Hans de Goede , Ben Widawsky , "open list:DOCUMENTATION" Subject: Re: [PATCH v3 3/5] drivers/acpi: Introduce Platform Firmware Runtime Update device driver Message-ID: <20211005041231.GB7134@chenyu5-mobl1> References: <90d270c031401430445cb2c4ba1b9b0c265cf9d4.1631802163.git.yu.c.chen@intel.com> <20210922090442.GA16963@chenyu5-mobl1> <20210922163321.GA31068@chenyu5-mobl1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, Sep 27, 2021 at 07:40:39PM +0200, Rafael J. Wysocki wrote: > On Wed, Sep 22, 2021 at 7:28 PM Greg Kroah-Hartman > wrote: > > > > On Thu, Sep 23, 2021 at 12:33:21AM +0800, Chen Yu wrote: > > > On Wed, Sep 22, 2021 at 11:10:02AM +0200, Greg Kroah-Hartman wrote: > > > > On Wed, Sep 22, 2021 at 05:04:42PM +0800, Chen Yu wrote: > > > > > Hi Greg, > > > > > On Tue, Sep 21, 2021 at 05:59:05PM +0200, Greg Kroah-Hartman wrote: > > > > > > On Fri, Sep 17, 2021 at 12:02:18AM +0800, Chen Yu wrote: > > > > > > > Introduce the pfru_update driver which can be used for Platform Firmware > > > > > > > Runtime code injection and driver update. The user is expected to provide > > > > > > > the update firmware in the form of capsule file, and pass it to the driver > > > > > > > via ioctl. Then the driver would hand this capsule file to the Platform > > > > > > > Firmware Runtime Update via the ACPI device _DSM method. At last the low > > > > > > > level Management Mode would do the firmware update. > > > > > > > > > > > > > > Signed-off-by: Chen Yu [snip] > > > > > > > +static struct miscdevice pfru_misc_dev = { > > > > > > > + .minor = MISC_DYNAMIC_MINOR, > > > > > > > + .name = "pfru_update", > > > > > > > + .nodename = "pfru/update", > > > > > > > > > > > > Why is this in a subdirectory? What requires this? Why not just > > > > > > "pfru"? > > > > > > > > > > > The pfru directory might be reused for pfru_telemetry device, whose driver > > > > > is in 4/5 patch, I'll Cc you with the whole patch set in next version. > > > > > > > > "might be" is not a valid reason. Why does this simple driver deserve a > > > > whole /dev/ subdirectory? > > > > > > > There are pfru_update and pfru_telemetry in the patch, and there is plan to > > > add a pfru_prm device in the future, which stands for "Platform Runtime Mechanism". > > > I'll move them to /dev/ in next version. > > > > That is a very generic name for a very platform specific and arch > > specific interface. As this is an ACPI interface, why not use that name > > prefix? > > It is not supposed to be either arch-specific or platform-specific. > The spec is hosted by the UEFI Forum and it is fairly generic IIUC. > In principle, it could be used to update any kind of platform firmware > possible to update without system restart. > > That said, the I/F to the platform firmware is based on ACPI methods, > so "acpi_" would be a reasonable prefix choice. Ok, will change it in next version. Thanks, Chenyu