Re: [PATCH v4 2/2] hwmon: (asus_wmi_sensors) Support X370 Asus WMI.

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2620 bytes --]

Hi Denis,

I love your patch! Yet something to improve:

[auto build test ERROR on 39b483aa38995329326988cbc4077422bebc175a]

url:    https://github.com/0day-ci/linux/commits/Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740
base:   39b483aa38995329326988cbc4077422bebc175a
config: ia64-randconfig-r015-20211011 (attached as .config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/134088f1e04948512edbb1c28c6031b0b9115403
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Denis-Pauk/Update-ASUS-WMI-supported-boards/20211011-050740
        git checkout 134088f1e04948512edbb1c28c6031b0b9115403
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/hwmon/asus_wmi_sensors.c: In function 'asus_wmi_call_method':
>> drivers/hwmon/asus_wmi_sensors.c:182:18: error: implicit declaration of function 'wmi_evaluate_method'; did you mean 'wmidev_evaluate_method'? [-Werror=implicit-function-declaration]
     182 |         status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input, output);
         |                  ^~~~~~~~~~~~~~~~~~~
         |                  wmidev_evaluate_method
   drivers/hwmon/asus_wmi_sensors.c: In function 'asus_wmi_probe':
>> drivers/hwmon/asus_wmi_sensors.c:580:14: error: implicit declaration of function 'wmi_has_guid' [-Werror=implicit-function-declaration]
     580 |         if (!wmi_has_guid(ASUSWMI_MONITORING_GUID))
         |              ^~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +182 drivers/hwmon/asus_wmi_sensors.c

   173	
   174	/*
   175	 * Universal method for calling WMI method
   176	 */
   177	static int asus_wmi_call_method(u32 method_id, u32 *args, struct acpi_buffer *output)
   178	{
   179		struct acpi_buffer input = {(acpi_size) sizeof(*args), args };
   180		acpi_status status;
   181	
 > 182		status = wmi_evaluate_method(ASUSWMI_MONITORING_GUID, 0, method_id, &input, output);
   183		if (ACPI_FAILURE(status))
   184			return -EIO;
   185	
   186		return 0;
   187	}
   188	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29145 bytes --]