From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C51AC433EF for ; Wed, 20 Oct 2021 15:32:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7AD286138F for ; Wed, 20 Oct 2021 15:32:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229952AbhJTPex (ORCPT ); Wed, 20 Oct 2021 11:34:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:53454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbhJTPew (ORCPT ); Wed, 20 Oct 2021 11:34:52 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB56D61373; Wed, 20 Oct 2021 15:32:36 +0000 (UTC) Date: Wed, 20 Oct 2021 11:32:34 -0400 From: Steven Rostedt To: Kalesh Singh Cc: surenb@google.com, hridya@google.com, namhyung@kernel.org, kernel-team@android.com, Jonathan Corbet , Ingo Molnar , Shuah Khan , Masami Hiramatsu , Tom Zanussi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 1/5] tracing: Add support for creating hist trigger variables from literal Message-ID: <20211020113234.45657902@gandalf.local.home> In-Reply-To: <20211020013153.4106001-2-kaleshsingh@google.com> References: <20211020013153.4106001-1-kaleshsingh@google.com> <20211020013153.4106001-2-kaleshsingh@google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, 19 Oct 2021 18:31:38 -0700 Kalesh Singh wrote: > @@ -89,6 +91,8 @@ typedef u64 (*hist_field_fn_t) (struct hist_field *field, > #define HIST_FIELD_OPERANDS_MAX 2 > #define HIST_FIELDS_MAX (TRACING_MAP_FIELDS_MAX + TRACING_MAP_VARS_MAX) > #define HIST_ACTIONS_MAX 8 > +#define HIST_CONST_MAX 4 BTW, why is there a limit to the number of constants? -- Steve > +#define HIST_CONST_DIGITS_MAX 21 >