From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7EA4C433F5 for ; Tue, 26 Oct 2021 21:44:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A9656610EA for ; Tue, 26 Oct 2021 21:44:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237354AbhJZVqt (ORCPT ); Tue, 26 Oct 2021 17:46:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:35252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237248AbhJZVqs (ORCPT ); Tue, 26 Oct 2021 17:46:48 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8CBB360EDF; Tue, 26 Oct 2021 21:44:22 +0000 (UTC) Date: Tue, 26 Oct 2021 17:44:20 -0400 From: Steven Rostedt To: Kalesh Singh Cc: Masami Hiramatsu , surenb@google.com, hridya@google.com, namhyung@kernel.org, kernel-team@android.com, Jonathan Corbet , Ingo Molnar , Shuah Khan , Tom Zanussi , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v4 7/8] tracing/selftests: Add tests for hist trigger expression parsing Message-ID: <20211026174420.0056bde2@gandalf.local.home> In-Reply-To: References: <20211025200852.3002369-1-kaleshsingh@google.com> <20211025200852.3002369-8-kaleshsingh@google.com> <20211026214311.583c728d90d41778c38201dd@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, 26 Oct 2021 07:28:39 -0700 Kalesh Singh wrote: > > If this update has any meaning, please make a separate patch for this part. > > Hi Masami, > > Thanks for the feedback. The above change is to ensure we remove > triggers in the reverse order that we created them - important when > one trigger depends on another. I can split it out into a separate > patch and will add a README pattern check to the requires tag for > these tests. Also make sure to run all the ftracetests. When I ran it with this update, most of the other histogram tests failed. Even with your patches applied to the running kernel. -- Steve