From: Masami Hiramatsu <mhiramat@kernel.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
surenb@google.com, hridya@google.com, namhyung@kernel.org,
kernel-team@android.com, Jonathan Corbet <corbet@lwn.net>,
Ingo Molnar <mingo@redhat.com>, Shuah Khan <shuah@kernel.org>,
Tom Zanussi <zanussi@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v4 7/8] tracing/selftests: Add tests for hist trigger expression parsing
Date: Wed, 27 Oct 2021 12:14:20 +0900 [thread overview]
Message-ID: <20211027121420.03a09fca1efc414189bb40bb@kernel.org> (raw)
In-Reply-To: <CAC_TJvf8areGd1rQMbJV4r+J6JP2-DWXBLQwKRZEOzNWL_rqrQ@mail.gmail.com>
Hi Kalesh,
On Tue, 26 Oct 2021 18:15:34 -0700
Kalesh Singh <kaleshsingh@google.com> wrote:
> On Tue, Oct 26, 2021 at 5:20 PM Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > On Tue, 26 Oct 2021 16:36:03 -0700
> > Kalesh Singh <kaleshsingh@google.com> wrote:
> >
> > > On my setup I without any of the changes applied (config hist triggers enabled):
> > >
> > > ./ftracetests
> > >
> > > # of passed: 41
> > > # of failed: 40
> > > # of unresolved: 0
> > > # of untested: 0
> > > # of unsupported: 32
> > > # of xfailed: 0
> > > # of undefined(test bug): 0
> > >
> > > Do all the tests pass for you, before any of the changes in this
> > > series? Maybe some of the tests need updating?
> >
> > All my tests past, and I don't push any code if they fail.
> >
> > I'd like to understand why you have these failures. Are the test from
> > the kernel you are testing?
>
> The results are from the kernel before I apply any of the patches. I
> am testing on an Android emulator (cuttlefish) with 5.15.0-rc6 kernel.
> The tests clearly work so it must be something on my end. I'll
> investigate and get back to you.
Interesting. There should be test logs under logs/ directory in the
ftracetest. Can you share the logs/*/ftracetest.log and your kernel kconfig?
Thank you,
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2021-10-27 3:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 20:08 [PATCH v4 0/8] tracing: Extend histogram triggers expression parsing Kalesh Singh
2021-10-25 20:08 ` [PATCH v4 1/8] tracing: Add support for creating hist trigger variables from literal Kalesh Singh
2021-10-25 20:08 ` [PATCH v4 2/8] tracing: Add division and multiplication support for hist triggers Kalesh Singh
2021-10-25 20:08 ` [PATCH v4 3/8] tracing: Fix operator precedence for hist triggers expression Kalesh Singh
2021-10-25 20:08 ` [PATCH v4 4/8] tracing/histogram: Simplify handling of .sym-offset in expressions Kalesh Singh
2021-10-25 20:08 ` [PATCH v4 5/8] tracing/histogram: Covert expr to const if both operands are constants Kalesh Singh
2021-10-25 20:08 ` [PATCH v4 6/8] tracing/histogram: Optimize division by a power of 2 Kalesh Singh
2021-10-26 19:14 ` Steven Rostedt
2021-10-26 23:39 ` Kalesh Singh
2021-10-27 0:18 ` Steven Rostedt
2021-10-27 1:09 ` Kalesh Singh
2021-10-27 1:15 ` Steven Rostedt
2021-10-27 1:31 ` Kalesh Singh
2021-10-27 2:21 ` Steven Rostedt
2021-10-27 3:15 ` Steven Rostedt
2021-10-27 4:04 ` Kalesh Singh
2021-10-27 14:06 ` Steven Rostedt
2021-10-25 20:08 ` [PATCH v4 7/8] tracing/selftests: Add tests for hist trigger expression parsing Kalesh Singh
2021-10-26 12:43 ` Masami Hiramatsu
2021-10-26 14:28 ` Kalesh Singh
2021-10-26 21:44 ` Steven Rostedt
2021-10-26 23:36 ` Kalesh Singh
2021-10-27 0:20 ` Steven Rostedt
2021-10-27 1:15 ` Kalesh Singh
2021-10-27 3:14 ` Masami Hiramatsu [this message]
[not found] ` <CAC_TJvdMXd+wnvvs7XrTmT2-iyepr==hH9Kkd_T9_f3jd3Edrg@mail.gmail.com>
2021-10-27 14:31 ` Steven Rostedt
2021-10-27 14:52 ` Masami Hiramatsu
2021-10-27 15:01 ` Steven Rostedt
2021-10-27 15:50 ` Steven Rostedt
[not found] ` <CAC_TJvehyzE4yvnn9ZvG7qnU6H9u-6mTauvqhPJjAUHvi4ebfg@mail.gmail.com>
2021-10-27 17:17 ` Steven Rostedt
2021-10-27 2:34 ` Masami Hiramatsu
2021-10-27 17:36 ` Steven Rostedt
2021-10-26 15:07 ` Steven Rostedt
[not found] ` <20211029064818.GG737@xsang-OptiPlex-9020>
2021-10-29 12:00 ` [tracing/selftests] cfece71411: kernel-selftests.ftrace.event_trigger_-_test_inter-event_histogram_trigger_onchange_action.fail Masami Hiramatsu
2021-10-29 13:10 ` Steven Rostedt
2021-11-01 3:43 ` [LKP] " Li Zhijian
2021-10-25 20:08 ` [PATCH v4 8/8] tracing/histogram: Document expression arithmetic and constants Kalesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211027121420.03a09fca1efc414189bb40bb@kernel.org \
--to=mhiramat@kernel.org \
--cc=corbet@lwn.net \
--cc=hridya@google.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=surenb@google.com \
--cc=zanussi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).