linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Zhaoyu Liu <zackary.liu.pro@gmail.com>
Cc: corbet@lwn.net, mingo@redhat.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: ftrace: fix the wrong path of tracefs
Date: Sat, 13 Nov 2021 09:11:45 -0500	[thread overview]
Message-ID: <20211113091145.05ba14b5@rorschach.local.home> (raw)
In-Reply-To: <20211113133722.GA11656@pc>

On Sat, 13 Nov 2021 21:37:34 +0800
Zhaoyu Liu <zackary.liu.pro@gmail.com> wrote:

> Delete "tracing" due to it has been included in /proc/mounts.
> Delete "echo nop > $tracefs/tracing/current_tracer", maybe
> this command is redundant.
> 
> Signed-off-by: Zhaoyu Liu <zackary.liu.pro@gmail.com>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Jon,

Can you take this through your tree?

Thanks,

-- Steve


> ---
>  Documentation/trace/ftrace.rst | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> index 4e5b26f03d5b..b3166c4a7867 100644
> --- a/Documentation/trace/ftrace.rst
> +++ b/Documentation/trace/ftrace.rst
> @@ -2442,11 +2442,10 @@ Or this simple script!
>    #!/bin/bash
>  
>    tracefs=`sed -ne 's/^tracefs \(.*\) tracefs.*/\1/p' /proc/mounts`
> -  echo nop > $tracefs/tracing/current_tracer
> -  echo 0 > $tracefs/tracing/tracing_on
> -  echo $$ > $tracefs/tracing/set_ftrace_pid
> -  echo function > $tracefs/tracing/current_tracer
> -  echo 1 > $tracefs/tracing/tracing_on
> +  echo 0 > $tracefs/tracing_on
> +  echo $$ > $tracefs/set_ftrace_pid
> +  echo function > $tracefs/current_tracer
> +  echo 1 > $tracefs/tracing_on
>    exec "$@"
>  
>  


  reply	other threads:[~2021-11-13 14:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13 13:37 [PATCH] docs: ftrace: fix the wrong path of tracefs Zhaoyu Liu
2021-11-13 14:11 ` Steven Rostedt [this message]
2021-11-15  9:51   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211113091145.05ba14b5@rorschach.local.home \
    --to=rostedt@goodmis.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=zackary.liu.pro@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).