linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	coresight@lists.linaro.org, corbet@lwn.net,
	suzuki.poulose@arm.com
Subject: Re: [PATCH] Documentation: coresight: Fix documentation issue
Date: Mon, 22 Nov 2021 09:55:43 -0700	[thread overview]
Message-ID: <20211122165543.GB2686563@p14s> (raw)
In-Reply-To: <20211117164220.14883-1-mike.leach@linaro.org>

Good day Mike,

On Wed, Nov 17, 2021 at 04:42:20PM +0000, Mike Leach wrote:
> Fix the description of the directories and attributes used
> in cs_etm as used by perf.
> 
> Drop the references to the 'configurations' sub-directory which
> had been removed in an earlier version of the patchset.
> 
> Fixes: f71cd93d5ea4 ("Documentation: coresight: Add documentation for CoreSight config")
> Reported-by: German Gomex <german.gomez@arm.com>
> Signed-off-by: Mike Leach <mike.leach@linaro.org>
> ---
>  .../trace/coresight/coresight-config.rst         | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)

I have applied your patch.

Thanks,
Mathieu

> 
> diff --git a/Documentation/trace/coresight/coresight-config.rst b/Documentation/trace/coresight/coresight-config.rst
> index a4e3ef295240..6ed13398ca2c 100644
> --- a/Documentation/trace/coresight/coresight-config.rst
> +++ b/Documentation/trace/coresight/coresight-config.rst
> @@ -211,19 +211,13 @@ also declared in the perf 'cs_etm' event infrastructure so that they can
>  be selected when running trace under perf::
>  
>      $ ls /sys/devices/cs_etm
> -    configurations  format  perf_event_mux_interval_ms  sinks  type
> -    events  nr_addr_filters  power
> +    cpu0  cpu2  events  nr_addr_filters		power  subsystem  uevent
> +    cpu1  cpu3  format  perf_event_mux_interval_ms	sinks  type
>  
> -Key directories here are 'configurations' - which lists the loaded
> -configurations, and 'events' - a generic perf directory which allows
> -selection on the perf command line.::
> +The key directory here is 'events' - a generic perf directory which allows
> +selection on the perf command line. As with the sinks entries, this provides
> +a hash of the configuration name.
>  
> -    $ ls configurations/
> -    autofdo
> -    $ cat configurations/autofdo
> -    0xa7c3dddd
> -
> -As with the sinks entries, this provides a hash of the configuration name.
>  The entry in the 'events' directory uses perfs built in syntax generator
>  to substitute the syntax for the name when evaluating the command::
>  
> -- 
> 2.17.1
> 

      parent reply	other threads:[~2021-11-22 16:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-17 16:42 [PATCH] Documentation: coresight: Fix documentation issue Mike Leach
2021-11-18 16:42 ` Mathieu Poirier
2021-11-22 16:55 ` Mathieu Poirier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211122165543.GB2686563@p14s \
    --to=mathieu.poirier@linaro.org \
    --cc=corbet@lwn.net \
    --cc=coresight@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=mike.leach@linaro.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).