From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Linux Doc Mailing List" <linux-doc@vger.kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Akira Yokosawa" <akiyks@gmail.com>,
"Jani Nikula" <jani.nikula@linux.intel.com>,
"Nícolas F. R. A. Prado" <nfraprado@protonmail.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Andrew Klychkov" <andrew.a.klychkov@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] docs: allow selecting a Sphinx theme
Date: Thu, 2 Dec 2021 12:47:00 +0100 [thread overview]
Message-ID: <20211202124700.7e395897@coco.lan> (raw)
In-Reply-To: <CANiq72nu9TvLzxxj64b+EwFicwGexT7VTmVYVnVDzQgwkk+9ZA@mail.gmail.com>
Em Thu, 2 Dec 2021 12:24:53 +0100
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> escreveu:
> On Wed, Dec 1, 2021 at 6:59 PM Mauro Carvalho Chehab
> <mchehab+huawei@kernel.org> wrote:
> >
> > Instead of having RTD as an almost mandatory theme, allow the
> > user to select other themes via a THEMES environment var.
> >
> > There's a catch, though: as the current theme override logic is
> > dependent of the RTD theme, we need to move the code which
> > adds the CSS overrides to be inside the RTD theme logic.
>
> Does Sphinx support leaving the selection of the theme to "runtime",
> i.e. to let users pick a theme from a few from a combobox (e.g.
> light/dark)?
>
> I assume not, but asking just in case.
The RTD dark theme allows that. It basically places a <sun>/<moon>
icon. When such icon is clicked, it switches between light/dark.
Thanks,
Mauro
next prev parent reply other threads:[~2021-12-02 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 17:59 [PATCH v3 0/4] docs: add better support for Sphinx themes and CSS Mauro Carvalho Chehab
2021-12-01 17:59 ` [PATCH v3 1/4] docs: allow selecting a Sphinx theme Mauro Carvalho Chehab
2021-12-02 11:24 ` Miguel Ojeda
2021-12-02 11:47 ` Mauro Carvalho Chehab [this message]
2021-12-02 11:50 ` Miguel Ojeda
2021-12-03 14:08 ` Mauro Carvalho Chehab
2021-12-06 19:12 ` Jonathan Corbet
2021-12-06 20:14 ` Mauro Carvalho Chehab
2021-12-06 22:55 ` Jonathan Corbet
2021-12-07 9:16 ` Mauro Carvalho Chehab
2021-12-07 9:20 ` Mauro Carvalho Chehab
2021-12-01 17:59 ` [PATCH v3 2/4] docs: allow to pass extra CSS themes via make Mauro Carvalho Chehab
2021-12-01 17:59 ` [PATCH v3 3/4] docs: set format for the classic mode Mauro Carvalho Chehab
2021-12-01 17:59 ` [PATCH v3 4/4] docs: add support for RTD dark mode Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202124700.7e395897@coco.lan \
--to=mchehab+huawei@kernel.org \
--cc=akiyks@gmail.com \
--cc=andrew.a.klychkov@gmail.com \
--cc=corbet@lwn.net \
--cc=jani.nikula@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=nfraprado@protonmail.com \
--cc=ojeda@kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).