From: Jithu Joseph <jithu.joseph@intel.com>
To: hdegoede@redhat.com, markgross@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
corbet@lwn.net, gregkh@linuxfoundation.org,
andriy.shevchenko@linux.intel.com, jithu.joseph@intel.com,
ashok.raj@intel.com, tony.luck@intel.com, rostedt@goodmis.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
platform-driver-x86@vger.kernel.org, patches@lists.linux.dev,
ravi.v.shankar@intel.com
Subject: [RFC 01/10] x86/microcode/intel: expose collect_cpu_info_early() for IFS
Date: Tue, 1 Mar 2022 11:54:48 -0800 [thread overview]
Message-ID: <20220301195457.21152-2-jithu.joseph@intel.com> (raw)
In-Reply-To: <20220301195457.21152-1-jithu.joseph@intel.com>
IFS uses a image provided by Intel that can be regarded as firmware.
IFS image carries the Processor Signature such as family/model/stepping
similar to what we find in the microcode header.
Expose collect_cpu_info_early() and cpu_signatures_match() for IFS image
sanity check.
No functional change.
Originally-by: Kyung Min Park <kyung.min.park@intel.com>
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Reviewed-by: Ashok Raj <ashok.raj@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
---
arch/x86/include/asm/microcode_intel.h | 6 ++++++
arch/x86/kernel/cpu/microcode/intel.c | 8 +++++---
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/arch/x86/include/asm/microcode_intel.h b/arch/x86/include/asm/microcode_intel.h
index d85a07d7154f..ec19eeac535b 100644
--- a/arch/x86/include/asm/microcode_intel.h
+++ b/arch/x86/include/asm/microcode_intel.h
@@ -74,12 +74,18 @@ extern void load_ucode_intel_ap(void);
extern void show_ucode_info_early(void);
extern int __init save_microcode_in_initrd_intel(void);
void reload_ucode_intel(void);
+int collect_cpu_info_early(struct ucode_cpu_info *uci);
+bool cpu_signatures_match(unsigned int s1, unsigned int p1,
+ unsigned int s2, unsigned int p2);
#else
static inline __init void load_ucode_intel_bsp(void) {}
static inline void load_ucode_intel_ap(void) {}
static inline void show_ucode_info_early(void) {}
static inline int __init save_microcode_in_initrd_intel(void) { return -EINVAL; }
static inline void reload_ucode_intel(void) {}
+static inline void collect_cpu_info_early(struct ucode_cpu_info *uci) {}
+static inline void cpu_signatures_match(unsigned int s1, unsigned int p1,
+ unsigned int s2, unsigned int p2) {}
#endif
#endif /* _ASM_X86_MICROCODE_INTEL_H */
diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
index d28a9f8f3fec..360ec06eec1e 100644
--- a/arch/x86/kernel/cpu/microcode/intel.c
+++ b/arch/x86/kernel/cpu/microcode/intel.c
@@ -45,8 +45,8 @@ static struct microcode_intel *intel_ucode_patch;
/* last level cache size per core */
static int llc_size_per_core;
-static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,
- unsigned int s2, unsigned int p2)
+bool cpu_signatures_match(unsigned int s1, unsigned int p1,
+ unsigned int s2, unsigned int p2)
{
if (s1 != s2)
return false;
@@ -58,6 +58,7 @@ static inline bool cpu_signatures_match(unsigned int s1, unsigned int p1,
/* ... or they intersect. */
return p1 & p2;
}
+EXPORT_SYMBOL_GPL(cpu_signatures_match);
/*
* Returns 1 if update has been found, 0 otherwise.
@@ -342,7 +343,7 @@ scan_microcode(void *data, size_t size, struct ucode_cpu_info *uci, bool save)
return patch;
}
-static int collect_cpu_info_early(struct ucode_cpu_info *uci)
+int collect_cpu_info_early(struct ucode_cpu_info *uci)
{
unsigned int val[2];
unsigned int family, model;
@@ -372,6 +373,7 @@ static int collect_cpu_info_early(struct ucode_cpu_info *uci)
return 0;
}
+EXPORT_SYMBOL_GPL(collect_cpu_info_early);
static void show_saved_mc(void)
{
--
2.17.1
next prev parent reply other threads:[~2022-03-01 19:55 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 19:54 [RFC 00/10] Introduce In Field Scan driver Jithu Joseph
2022-03-01 19:54 ` Jithu Joseph [this message]
2022-03-01 20:08 ` [RFC 01/10] x86/microcode/intel: expose collect_cpu_info_early() for IFS Greg KH
2022-03-02 0:56 ` Joseph, Jithu
2022-03-02 10:30 ` Borislav Petkov
2022-03-03 1:34 ` Joseph, Jithu
2022-03-01 19:54 ` [RFC 02/10] Documentation: In-Field Scan Jithu Joseph
2022-03-01 20:07 ` Greg KH
2022-03-02 0:58 ` Joseph, Jithu
2022-03-01 19:54 ` [RFC 03/10] platform/x86/intel/ifs: Add driver for " Jithu Joseph
2022-03-02 23:24 ` Williams, Dan J
2022-03-02 23:31 ` Raj, Ashok
2022-03-03 0:02 ` Luck, Tony
2022-03-03 2:04 ` Joseph, Jithu
2022-03-01 19:54 ` [RFC 04/10] platform/x86/intel/ifs: Load IFS Image Jithu Joseph
2022-03-03 2:58 ` Williams, Dan J
2022-03-01 19:54 ` [RFC 05/10] platform/x86/intel/ifs: Check IFS Image sanity Jithu Joseph
2022-03-01 19:54 ` [RFC 06/10] platform/x86/intel/ifs: Authenticate and copy to secured memory Jithu Joseph
2022-03-01 19:54 ` [RFC 07/10] platform/x86/intel/ifs: Create kthreads for online cpus for scan test Jithu Joseph
2022-03-03 4:17 ` Williams, Dan J
2022-03-03 19:59 ` Luck, Tony
2022-03-04 19:20 ` Joseph, Jithu
2022-03-07 16:52 ` Dan Williams
2022-03-07 17:46 ` Luck, Tony
2022-03-10 21:42 ` Kok, Auke
2022-03-01 19:54 ` [RFC 08/10] platform/x86/intel/ifs: Add IFS sysfs interface Jithu Joseph
2022-03-04 0:31 ` Williams, Dan J
2022-03-04 16:51 ` Luck, Tony
2022-03-04 20:42 ` Joseph, Jithu
2022-03-04 21:01 ` Luck, Tony
2022-03-21 21:15 ` Luck, Tony
2022-03-07 17:38 ` Dan Williams
2022-03-07 19:09 ` Joseph, Jithu
2022-03-07 19:15 ` Dan Williams
2022-03-07 19:55 ` Joseph, Jithu
2022-03-07 20:25 ` Dan Williams
2022-03-07 20:56 ` Joseph, Jithu
2022-03-07 21:28 ` Dan Williams
2022-03-07 21:30 ` gregkh
2022-03-07 21:33 ` Luck, Tony
2022-03-01 19:54 ` [RFC 09/10] platform/x86/intel/ifs: add ABI documentation for IFS Jithu Joseph
2022-03-04 0:57 ` Williams, Dan J
2022-03-01 19:54 ` [RFC 10/10] trace: platform/x86/intel/ifs: Add trace point to track Intel IFS operations Jithu Joseph
2022-03-01 20:17 ` Steven Rostedt
2022-03-02 1:02 ` Joseph, Jithu
2022-03-01 20:10 ` [RFC 00/10] Introduce In Field Scan driver Greg KH
2022-03-01 20:14 ` Greg KH
2022-03-14 23:10 ` Luck, Tony
2022-03-15 7:34 ` Greg KH
2022-03-15 14:59 ` Luck, Tony
2022-03-15 15:26 ` Greg KH
2022-03-15 16:04 ` Dan Williams
2022-03-15 16:09 ` Dan Williams
2022-03-15 16:10 ` Luck, Tony
2022-03-16 8:09 ` Greg KH
2022-03-02 15:33 ` Steven Rostedt
2022-03-02 16:20 ` Greg KH
2022-03-02 13:59 ` Andy Lutomirski
2022-03-02 20:29 ` Luck, Tony
2022-03-02 21:18 ` Andy Lutomirski
2022-03-02 21:41 ` Luck, Tony
2022-03-02 23:11 ` Williams, Dan J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301195457.21152-2-jithu.joseph@intel.com \
--to=jithu.joseph@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=mingo@redhat.com \
--cc=patches@lists.linux.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).