From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.garry@huawei.com>
Cc: damien.lemoal@opensource.wdc.com, hch@lst.de,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
linux-doc@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2 2/2] libata: Inline ata_qc_new_init() in ata_scsi_qc_new()
Date: Tue, 5 Apr 2022 07:52:52 +0200 [thread overview]
Message-ID: <20220405055252.GA23698@lst.de> (raw)
In-Reply-To: <1649083990-207133-3-git-send-email-john.garry@huawei.com>
On Mon, Apr 04, 2022 at 10:53:10PM +0800, John Garry wrote:
> From: Christoph Hellwig <hch@lst.de>
>
> It is a bit pointless to have ata_qc_new_init() in libata-core.c since it
> pokes scsi internals, so inline it in ata_scsi_qc_new() (in libata-scsi.c).
>
> <Christoph, please provide signed-off-by>
> [jpg, Take Christoph's change from list and form into a patch]
> Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Although I still think merging the two patches into one to avoid all
the churn would be much better.
next prev parent reply other threads:[~2022-04-05 5:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-04 14:53 [PATCH v2 0/2] libata: A tagging improvement and related code reorg John Garry
2022-04-04 14:53 ` [PATCH v2 1/2] libata: Use scsi cmnd budget token for qc tag for SAS host John Garry
2022-04-06 1:39 ` Damien Le Moal
2022-04-06 7:12 ` John Garry
2022-04-06 8:10 ` Damien Le Moal
2022-04-04 14:53 ` [PATCH v2 2/2] libata: Inline ata_qc_new_init() in ata_scsi_qc_new() John Garry
2022-04-05 5:52 ` Christoph Hellwig [this message]
2022-04-06 1:48 ` Damien Le Moal
2022-04-06 7:16 ` John Garry
2022-04-06 8:10 ` Damien Le Moal
2022-04-06 8:11 ` Christoph Hellwig
2022-04-06 1:47 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220405055252.GA23698@lst.de \
--to=hch@lst.de \
--cc=damien.lemoal@opensource.wdc.com \
--cc=john.garry@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).