From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Luiz Angelo Daros de Luca <luizluca@gmail.com>,
George McCollister <george.mccollister@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next v2] docs: net: dsa: describe issues with checksum offload
Date: Thu, 14 Apr 2022 15:22:12 +0000 [thread overview]
Message-ID: <20220414152211.txmb3peuxs4rt4pw@skbuf> (raw)
In-Reply-To: <87tuawp493.fsf@kurt>
On Thu, Apr 14, 2022 at 08:29:12AM +0200, Kurt Kanzenbach wrote:
> On Wed Apr 13 2022, Vladimir Oltean wrote:
> > I've copied a bunch of new people to this email.
> >
> > TL;DR: Kurt/George/Andrew, on your systems with hellcreek/xrs700x/mv88e6060,
> > does the DSA master declare any of the following features as "on"?
> >
> > ethtool -k eth0 | grep tx-checksum-ip
>
> It's a Cyclone V with stmmac as master:
>
> |root@tsn:~# ethtool -k eth0 | grep tx-checksum-ip
> | tx-checksum-ipv4: on
> | tx-checksum-ip-generic: off [fixed]
> | tx-checksum-ipv6: on
>
> >
> > I would expect not. Otherwise, we've either found a bug, or discovered
> > the Sasquatch.
>
> Now, I'm wondering how this actually works. Anyway, I'll send a patch to
> add the missing skb_checksum_help().
>
> Thanks,
> Kurt
Thanks, Kurt.
It works because stmmac declares NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM in
ndev->hw_features but not in ndev->vlan_features. Whereas DSA inherits
what it inherits from ndev->vlan_features.
It's good to fix this in hellcreek anyway.
prev parent reply other threads:[~2022-04-14 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 23:03 [PATCH net-next v2] docs: net: dsa: describe issues with checksum offload Luiz Angelo Daros de Luca
2022-04-13 20:08 ` Vladimir Oltean
2022-04-13 20:49 ` Andrew Lunn
2022-04-13 20:53 ` Vladimir Oltean
2022-04-13 20:57 ` Andrew Lunn
2022-04-13 21:00 ` Vladimir Oltean
2022-04-14 2:48 ` Luiz Angelo Daros de Luca
2022-04-14 12:58 ` Vladimir Oltean
2022-04-15 8:01 ` Luiz Angelo Daros de Luca
2022-04-15 10:22 ` Vladimir Oltean
2022-04-16 5:30 ` Luiz Angelo Daros de Luca
2022-04-13 20:56 ` Andrew Lunn
2022-04-14 6:29 ` Kurt Kanzenbach
2022-04-14 15:22 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220414152211.txmb3peuxs4rt4pw@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=george.mccollister@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox