linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Aleksa Savic <savicaleksa83@gmail.com>
Cc: linux-hwmon@vger.kernel.org, Jack Doan <me@jackdoan.com>,
	Jean Delvare <jdelvare@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (aquacomputer_d5next) Add support for Aquacomputer Farbwerk
Date: Sat, 23 Apr 2022 09:34:22 -0700	[thread overview]
Message-ID: <20220423163422.GA3964519@roeck-us.net> (raw)
In-Reply-To: <YmQoEoU1UJ+KPhQ9@fedora>

On Sat, Apr 23, 2022 at 06:23:46PM +0200, Aleksa Savic wrote:
[ ... ]
> > > +	case USB_PRODUCT_ID_FARBWERK:
> > > +		priv->kind = farbwerk;
> > > +
> > 
> > 
> > Any special reason for this empty line ? It seems kind of random.
> > 
> > Guenter
> > 
> 
> That's how code in other cases of that switch is formatted (not visible
> from this patch directly), setting priv->kind and then the appropriate
> labels.
> 
Ah, ok. Looks odd here, but makes sense.

Thanks,
Guenter

  reply	other threads:[~2022-04-23 16:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-21  7:27 [PATCH] hwmon: (aquacomputer_d5next) Add support for Aquacomputer Farbwerk Aleksa Savic
2022-04-22  7:23 ` Aleksa Savic
2022-04-22 18:31 ` Guenter Roeck
2022-04-23 16:23   ` Aleksa Savic
2022-04-23 16:34     ` Guenter Roeck [this message]
2022-04-24  1:42 ` Guenter Roeck
2022-04-24  3:56   ` Jack Doan
     [not found]   ` <0bf6576c-c129-f8fb-19c3-e3fca797cfee@jackdoan.com>
2022-04-24  5:01     ` Guenter Roeck
2022-04-24  5:16       ` Aleksa Savic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220423163422.GA3964519@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=corbet@lwn.net \
    --cc=jdelvare@suse.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@jackdoan.com \
    --cc=savicaleksa83@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).