From: Hector Martin <marcan@marcan.st>
To: unlisted-recipients:; (no To-header on input)
Cc: Hector Martin <marcan@marcan.st>,
Anup Patel <anup.patel@broadcom.com>,
Vinod Koul <vkoul@kernel.org>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Mun Yew Tham <mun.yew.tham@intel.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Michal Simek <michal.simek@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: [PATCH 3/7] mailbox: ti-msgmgr Remove unused ti_msgmgr_queue_peek_data
Date: Mon, 2 May 2022 18:02:21 +0900 [thread overview]
Message-ID: <20220502090225.26478-4-marcan@marcan.st> (raw)
In-Reply-To: <20220502090225.26478-1-marcan@marcan.st>
This op was ambiguously specified, and the way it was interpreted for
this implementation is not useful. It has no users, so remove it.
Signed-off-by: Hector Martin <marcan@marcan.st>
---
drivers/mailbox/ti-msgmgr.c | 28 ----------------------------
1 file changed, 28 deletions(-)
diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c
index ddac423ac1a9..10881b812df2 100644
--- a/drivers/mailbox/ti-msgmgr.c
+++ b/drivers/mailbox/ti-msgmgr.c
@@ -309,33 +309,6 @@ static irqreturn_t ti_msgmgr_queue_rx_interrupt(int irq, void *p)
return IRQ_HANDLED;
}
-/**
- * ti_msgmgr_queue_peek_data() - Peek to see if there are any rx messages.
- * @chan: Channel Pointer
- *
- * Return: 'true' if there is pending rx data, 'false' if there is none.
- */
-static bool ti_msgmgr_queue_peek_data(struct mbox_chan *chan)
-{
- struct ti_queue_inst *qinst = chan->con_priv;
- struct device *dev = chan->mbox->dev;
- struct ti_msgmgr_inst *inst = dev_get_drvdata(dev);
- const struct ti_msgmgr_desc *desc = inst->desc;
- int msg_count;
-
- if (qinst->is_tx)
- return false;
-
- if (ti_msgmgr_queue_is_error(desc, qinst)) {
- dev_err(dev, "Error on channel %s\n", qinst->name);
- return false;
- }
-
- msg_count = ti_msgmgr_queue_get_num_messages(desc, qinst);
-
- return msg_count ? true : false;
-}
-
/**
* ti_msgmgr_last_tx_done() - See if all the tx messages are sent
* @chan: Channel pointer
@@ -744,7 +717,6 @@ static DEFINE_SIMPLE_DEV_PM_OPS(ti_msgmgr_pm_ops, ti_msgmgr_suspend, ti_msgmgr_r
static const struct mbox_chan_ops ti_msgmgr_chan_ops = {
.startup = ti_msgmgr_queue_startup,
.shutdown = ti_msgmgr_queue_shutdown,
- .peek_data = ti_msgmgr_queue_peek_data,
.last_tx_done = ti_msgmgr_last_tx_done,
.send_data = ti_msgmgr_send_data,
};
--
2.35.1
next prev parent reply other threads:[~2022-05-02 9:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 9:02 [PATCH 0/7] mailbox: apple: peek_data cleanup and implementation Hector Martin
2022-05-02 9:02 ` [PATCH 1/7] mailbox: zynq: Remove unused zynqmp_ipi_peek_data Hector Martin
2022-05-02 9:02 ` [PATCH 2/7] mailbox: sun6i: Unexport unused sun6i_msgbox_peek_data Hector Martin
2022-05-02 23:18 ` Samuel Holland
2022-05-02 9:02 ` Hector Martin [this message]
2022-05-02 9:02 ` [PATCH 4/7] mailbox: altera: Remove unused altera_mbox_peek_data Hector Martin
2022-05-02 9:02 ` [PATCH 5/7] mailbox: Rename peek_data to poll_data and fix documentation Hector Martin
2022-05-02 9:02 ` [PATCH 6/7] mailbox: apple: Implement flush() operation Hector Martin
2022-05-02 9:02 ` [PATCH 7/7] mailbox: apple: Implement poll_data() operation Hector Martin
2022-05-02 9:05 ` [PATCH 0/7] mailbox: apple: peek_data cleanup and implementation Hector Martin
2022-05-24 14:55 ` jassisinghbrar
2022-05-24 15:15 ` Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502090225.26478-4-marcan@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=anup.patel@broadcom.com \
--cc=arnd@arndb.de \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=michal.simek@xilinx.com \
--cc=mun.yew.tham@intel.com \
--cc=samuel@sholland.org \
--cc=sven@svenpeter.dev \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).