From: Hector Martin <marcan@marcan.st>
To: unlisted-recipients:; (no To-header on input)
Cc: Hector Martin <marcan@marcan.st>,
Anup Patel <anup.patel@broadcom.com>,
Vinod Koul <vkoul@kernel.org>, Sven Peter <sven@svenpeter.dev>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Mun Yew Tham <mun.yew.tham@intel.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Michal Simek <michal.simek@xilinx.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev
Subject: [PATCH 4/7] mailbox: altera: Remove unused altera_mbox_peek_data
Date: Mon, 2 May 2022 18:02:22 +0900 [thread overview]
Message-ID: <20220502090225.26478-5-marcan@marcan.st> (raw)
In-Reply-To: <20220502090225.26478-1-marcan@marcan.st>
This op was ambiguously specified, and the way it was interpreted for
this implementation is not useful. It has no users, so remove it.
Signed-off-by: Hector Martin <marcan@marcan.st>
---
drivers/mailbox/mailbox-altera.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/mailbox/mailbox-altera.c b/drivers/mailbox/mailbox-altera.c
index afb320e9d69c..30de424df371 100644
--- a/drivers/mailbox/mailbox-altera.c
+++ b/drivers/mailbox/mailbox-altera.c
@@ -238,13 +238,6 @@ static bool altera_mbox_last_tx_done(struct mbox_chan *chan)
return altera_mbox_full(mbox) ? false : true;
}
-static bool altera_mbox_peek_data(struct mbox_chan *chan)
-{
- struct altera_mbox *mbox = mbox_chan_to_altera_mbox(chan);
-
- return altera_mbox_pending(mbox) ? true : false;
-}
-
static int altera_mbox_startup(struct mbox_chan *chan)
{
struct altera_mbox *mbox = mbox_chan_to_altera_mbox(chan);
@@ -279,7 +272,6 @@ static const struct mbox_chan_ops altera_mbox_ops = {
.startup = altera_mbox_startup,
.shutdown = altera_mbox_shutdown,
.last_tx_done = altera_mbox_last_tx_done,
- .peek_data = altera_mbox_peek_data,
};
static int altera_mbox_probe(struct platform_device *pdev)
--
2.35.1
next prev parent reply other threads:[~2022-05-02 9:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 9:02 [PATCH 0/7] mailbox: apple: peek_data cleanup and implementation Hector Martin
2022-05-02 9:02 ` [PATCH 1/7] mailbox: zynq: Remove unused zynqmp_ipi_peek_data Hector Martin
2022-05-02 9:02 ` [PATCH 2/7] mailbox: sun6i: Unexport unused sun6i_msgbox_peek_data Hector Martin
2022-05-02 23:18 ` Samuel Holland
2022-05-02 9:02 ` [PATCH 3/7] mailbox: ti-msgmgr Remove unused ti_msgmgr_queue_peek_data Hector Martin
2022-05-02 9:02 ` Hector Martin [this message]
2022-05-02 9:02 ` [PATCH 5/7] mailbox: Rename peek_data to poll_data and fix documentation Hector Martin
2022-05-02 9:02 ` [PATCH 6/7] mailbox: apple: Implement flush() operation Hector Martin
2022-05-02 9:02 ` [PATCH 7/7] mailbox: apple: Implement poll_data() operation Hector Martin
2022-05-02 9:05 ` [PATCH 0/7] mailbox: apple: peek_data cleanup and implementation Hector Martin
2022-05-24 14:55 ` jassisinghbrar
2022-05-24 15:15 ` Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502090225.26478-5-marcan@marcan.st \
--to=marcan@marcan.st \
--cc=alyssa@rosenzweig.io \
--cc=anup.patel@broadcom.com \
--cc=arnd@arndb.de \
--cc=dmaengine@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=michal.simek@xilinx.com \
--cc=mun.yew.tham@intel.com \
--cc=samuel@sholland.org \
--cc=sven@svenpeter.dev \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).