From: Andrew Morton <akpm@linux-foundation.org>
To: Muchun Song <songmuchun@bytedance.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>,
corbet@lwn.net, mcgrof@kernel.org, keescook@chromium.org,
yzaikin@google.com, osalvador@suse.de, david@redhat.com,
masahiroy@kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
duanxiongchun@bytedance.com, smuchun@gmail.com
Subject: Re: [PATCH v9 2/4] mm: memory_hotplug: override memmap_on_memory when hugetlb_free_vmemmap=on
Date: Sat, 7 May 2022 14:05:08 -0700 [thread overview]
Message-ID: <20220507140508.38c9e211eae4715134f9fa31@linux-foundation.org> (raw)
In-Reply-To: <YnH1B1Al/oW3rbmu@FVFYT0MHHV2J.usts.net>
On Wed, 4 May 2022 11:37:43 +0800 Muchun Song <songmuchun@bytedance.com> wrote:
> > Freeing HugeTLB vmemmap pages is not compatible with allocating memmap on
> > hot added memory. If "hugetlb_free_vmemmap=on" and
> > memory_hotplug.memmap_on_memory" are both passed on the kernel command line,
> > freeing hugetlb pages takes precedence. However, the global variable
> > memmap_on_memory will still be set to 1, even though we will not try to
> > allocate memmap on hot added memory.
> >
> > Not sure if that is more clear or not.
> >
>
> Clearer than mine.
I updated, thanks.
next prev parent reply other threads:[~2022-05-07 21:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 12:18 [PATCH v9 0/4] add hugetlb_optimize_vmemmap sysctl Muchun Song
2022-04-29 12:18 ` [PATCH v9 1/4] mm: hugetlb_vmemmap: disable hugetlb_optimize_vmemmap when struct page crosses page boundaries Muchun Song
2022-05-03 21:49 ` Mike Kravetz
2022-04-29 12:18 ` [PATCH v9 2/4] mm: memory_hotplug: override memmap_on_memory when hugetlb_free_vmemmap=on Muchun Song
2022-05-04 0:23 ` Mike Kravetz
2022-05-04 3:37 ` Muchun Song
2022-05-07 21:05 ` Andrew Morton [this message]
2022-04-29 12:18 ` [PATCH v9 3/4] mm: hugetlb_vmemmap: use kstrtobool for hugetlb_vmemmap param parsing Muchun Song
2022-05-04 0:42 ` Mike Kravetz
2022-04-29 12:18 ` [PATCH v9 4/4] mm: hugetlb_vmemmap: add hugetlb_optimize_vmemmap sysctl Muchun Song
2022-05-04 22:12 ` Mike Kravetz
2022-05-05 2:35 ` Muchun Song
2022-05-05 3:36 ` Mike Kravetz
2022-05-05 8:02 ` Muchun Song
2022-05-05 16:48 ` Mike Kravetz
2022-05-06 2:49 ` Muchun Song
2022-05-06 16:50 ` Mike Kravetz
2022-05-07 13:10 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220507140508.38c9e211eae4715134f9fa31@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=duanxiongchun@bytedance.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=smuchun@gmail.com \
--cc=songmuchun@bytedance.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).