Linux Documentation
 help / color / mirror / Atom feed
From: Chen Wandun <chenwandun@huawei.com>
To: <linux-kernel@vger.kernel.org>, <hannes@cmpxchg.org>,
	<surenb@google.com>, <alexs@kernel.org>, <corbet@lwn.net>,
	<linux-doc@vger.kernel.org>
Subject: [PATCH 1/2] psi: add support for multi level pressure stall trigger
Date: Mon, 16 May 2022 11:35:23 +0800	[thread overview]
Message-ID: <20220516033524.3130816-1-chenwandun@huawei.com> (raw)

Nowadays, psi events are triggered when stall time exceed
stall threshold, but no any different between these events.

Actually, events can be divide into multi level, each level
represent a different stall pressure, that is help to identify
pressure information more accurately.

echo "some 150000 350000 1000000" > /proc/pressure/memory would
add [150ms, 350ms) threshold for partial memory stall measured
within 1sec time window.

Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
 include/linux/psi_types.h |  3 ++-
 kernel/sched/psi.c        | 19 +++++++++++++------
 2 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/include/linux/psi_types.h b/include/linux/psi_types.h
index c7fe7c089718..2b1393c8bf90 100644
--- a/include/linux/psi_types.h
+++ b/include/linux/psi_types.h
@@ -119,7 +119,8 @@ struct psi_trigger {
 	enum psi_states state;
 
 	/* User-spacified threshold in ns */
-	u64 threshold;
+	u64 min_threshold;
+	u64 max_threshold;
 
 	/* List node inside triggers list */
 	struct list_head node;
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 6f9533c95b0a..17dd233b533a 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -541,7 +541,7 @@ static u64 update_triggers(struct psi_group *group, u64 now)
 
 			/* Calculate growth since last update */
 			growth = window_update(&t->win, now, total[t->state]);
-			if (growth < t->threshold)
+			if (growth < t->min_threshold || growth >= t->max_threshold)
 				continue;
 
 			t->pending_event = true;
@@ -1087,15 +1087,18 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group,
 {
 	struct psi_trigger *t;
 	enum psi_states state;
-	u32 threshold_us;
+	u32 min_threshold_us;
+	u32 max_threshold_us;
 	u32 window_us;
 
 	if (static_branch_likely(&psi_disabled))
 		return ERR_PTR(-EOPNOTSUPP);
 
-	if (sscanf(buf, "some %u %u", &threshold_us, &window_us) == 2)
+	if (sscanf(buf, "some %u %u %u", &min_threshold_us,
+				&max_threshold_us, &window_us) == 3)
 		state = PSI_IO_SOME + res * 2;
-	else if (sscanf(buf, "full %u %u", &threshold_us, &window_us) == 2)
+	else if (sscanf(buf, "full %u %u %u", &min_threshold_us,
+				&max_threshold_us, &window_us) == 3)
 		state = PSI_IO_FULL + res * 2;
 	else
 		return ERR_PTR(-EINVAL);
@@ -1107,8 +1110,11 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group,
 		window_us > WINDOW_MAX_US)
 		return ERR_PTR(-EINVAL);
 
+	if (min_threshold_us >= max_threshold_us)
+		return ERR_PTR(-EINVAL);
+
 	/* Check threshold */
-	if (threshold_us == 0 || threshold_us > window_us)
+	if (max_threshold_us > window_us)
 		return ERR_PTR(-EINVAL);
 
 	t = kmalloc(sizeof(*t), GFP_KERNEL);
@@ -1117,7 +1123,8 @@ struct psi_trigger *psi_trigger_create(struct psi_group *group,
 
 	t->group = group;
 	t->state = state;
-	t->threshold = threshold_us * NSEC_PER_USEC;
+	t->min_threshold = min_threshold_us * NSEC_PER_USEC;
+	t->max_threshold = max_threshold_us * NSEC_PER_USEC;
 	t->win.size = window_us * NSEC_PER_USEC;
 	window_reset(&t->win, 0, 0, 0);
 
-- 
2.25.1


             reply	other threads:[~2022-05-16  3:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16  3:35 Chen Wandun [this message]
2022-05-16  3:35 ` [PATCH 2/2] psi: add description about multi level pressure trigger Chen Wandun
2022-05-16  6:20 ` [PATCH 1/2] psi: add support for multi level pressure stall trigger Alex Shi
2022-05-16  8:21   ` Suren Baghdasaryan
2022-05-16  8:43     ` Suren Baghdasaryan
2022-05-17 12:46       ` Chen Wandun
2022-05-17 17:35         ` Suren Baghdasaryan
2022-05-18  9:55           ` Chen Wandun
2022-05-18 10:29         ` Alex Shi
2022-05-18 21:38           ` Suren Baghdasaryan
2022-05-19  6:15             ` Alex Shi
2022-05-19 18:34               ` Suren Baghdasaryan
2022-05-21  7:23               ` Chen Wandun
2022-05-21 10:13                 ` Alex Shi
2022-05-21 10:34                   ` Chen Wandun
2022-05-17  9:38     ` Chen Wandun
2022-05-17  9:08   ` Chen Wandun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220516033524.3130816-1-chenwandun@huawei.com \
    --to=chenwandun@huawei.com \
    --cc=alexs@kernel.org \
    --cc=corbet@lwn.net \
    --cc=hannes@cmpxchg.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=surenb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox