From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A445DC433EF for ; Fri, 3 Jun 2022 13:53:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244837AbiFCNxa (ORCPT ); Fri, 3 Jun 2022 09:53:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242859AbiFCNx3 (ORCPT ); Fri, 3 Jun 2022 09:53:29 -0400 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C98A3669D; Fri, 3 Jun 2022 06:53:28 -0700 (PDT) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id 938C61C0B9B; Fri, 3 Jun 2022 15:53:26 +0200 (CEST) Date: Fri, 3 Jun 2022 15:53:26 +0200 From: Pavel Machek To: Jonathan Corbet Cc: Bagas Sanjaya , linux-doc@vger.kernel.org, Bjorn Andersson , Marijn Suijten , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] leds: Add leds-qcom-lpg entry to documentation table of contents Message-ID: <20220603135326.GA14636@duo.ucw.cz> References: <20220603025735.17953-1-bagasdotme@gmail.com> <87bkv9x3qu.fsf@meer.lwn.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ZPt4rx8FFjLCG7dd" Content-Disposition: inline In-Reply-To: <87bkv9x3qu.fsf@meer.lwn.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org --ZPt4rx8FFjLCG7dd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > After merging linux-leds tree to the mainline [1], htmldocs build produ= ces > > a new warning: > > > > checking consistency... /home/bagas/repo/linux-stable/Documentation/led= s/leds-qcom-lpg.rst: WARNING: document isn't included in any toctree > > > > The warning above is because leds-qcom-lpg.rst is missing in the table = of > > contents. > > > > Add the missing entry. >=20 > The fix is good but ... >=20 > > [1]: https://lore.kernel.org/all/20220531200619.GA8906@duo.ucw.cz/ > > > > Fixes: e98a860f65428a ("leds: qcom-lpg: Require pattern to follow docum= entation") >=20 > ...I'm confused as to why you used that commit for a Fixes: tag. It > touched the file in question but didn't add it in the first place; I > think 24e2d05d1b68 is the droid you're looking for. Not sure if that is important, we don't need this in stable, do we? Anyway Acked-by: Pavel Machek =2E.. and I assume it goes through your tree? Best regards, Pavel --=20 People of Russia, stop Putin before his war on Ukraine escalates. --ZPt4rx8FFjLCG7dd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCYpoSVgAKCRAw5/Bqldv6 8nIWAKCWcLLIJQ32FCX2NeS6MLnFdl8klACdF6zcYv7cWK9iP753o88ODVFFAJk= =Hiy/ -----END PGP SIGNATURE----- --ZPt4rx8FFjLCG7dd--