From: "Daniel Müller" <deso@posteo.net>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Donald Hunter <donald.hunter@gmail.com>,
bpf@vger.kernel.org, linux-doc@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] bpf, docs: document BPF_MAP_TYPE_HASH and variants
Date: Thu, 14 Jul 2022 05:51:37 +0000 [thread overview]
Message-ID: <20220714055137.dsatpuyrwdlel2ck@vaio> (raw)
In-Reply-To: <99351eee-17b4-66e0-1b9e-7f798756780a@gmail.com>
On Thu, Jul 14, 2022 at 08:12:57AM +0700, Bagas Sanjaya wrote:
> On 7/14/22 04:16, Donald Hunter wrote:
> > This commit adds documentation for BPF_MAP_TYPE_HASH including kernel
> > version introduced, usage and examples. It also documents
> > BPF_MAP_TYPE_PERCPU_HASH, BPF_MAP_TYPE_LRU_HASH and
> > BPF_MAP_TYPE_LRU_PERCPU_HASH which are similar.
> >
>
> Please, please use imperative mood instead for patch description
> (that is, better write like "document BPF_MAP_TYPE_* types").
Can you elaborate why you make that recommendation, please?
Thanks,
Daniel
next prev parent reply other threads:[~2022-07-14 5:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 21:16 [PATCH] bpf, docs: document BPF_MAP_TYPE_HASH and variants Donald Hunter
2022-07-13 23:30 ` sdf
2022-07-14 22:20 ` Donald Hunter
2022-07-14 1:12 ` Bagas Sanjaya
2022-07-14 5:51 ` Daniel Müller [this message]
2022-07-14 8:10 ` Bagas Sanjaya
2022-07-14 21:53 ` Donald Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220714055137.dsatpuyrwdlel2ck@vaio \
--to=deso@posteo.net \
--cc=bagasdotme@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=donald.hunter@gmail.com \
--cc=linux-doc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox