From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: <linux-doc@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
<linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Alison Schofield <alison.schofield@intel.com>,
"Vishal Verma" <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Ben Widawsky" <bwidawsk@kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 2/3] cxl/region: describe targets and nr_targets members of cxl_region_params
Date: Thu, 4 Aug 2022 14:35:40 +0100 [thread overview]
Message-ID: <20220804143540.000041c2@huawei.com> (raw)
In-Reply-To: <20220804075448.98241-3-bagasdotme@gmail.com>
On Thu, 4 Aug 2022 14:54:47 +0700
Bagas Sanjaya <bagasdotme@gmail.com> wrote:
> Sphinx reported undescribed parameters in cxl_region_params struct:
>
> ./drivers/cxl/cxl.h:376: warning: Function parameter or member 'targets' not described in 'cxl_region_params'
> ./drivers/cxl/cxl.h:376: warning: Function parameter or member 'nr_targets' not described in 'cxl_region_params'
>
> Describe these members.
>
> Fixes: dd5ba0ebbdc414 ("cxl/region: Add a 'uuid' attribute")
That seems unlikely to be right tag. Probably b9686e8c8e39
With that tidied up.
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> drivers/cxl/cxl.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index 75674400cc8d41..65aaf15aa17e29 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -362,6 +362,8 @@ enum cxl_config_state {
> * @interleave_ways: number of endpoints in the region
> * @interleave_granularity: capacity each endpoint contributes to a stripe
> * @res: allocated iomem capacity for this region
> + * @targets: active ordered targets in current decoder configuration
> + * @nr_targets: number of targets
> *
> * State transitions are protected by the cxl_region_rwsem
> */
next prev parent reply other threads:[~2022-08-04 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-04 7:54 [PATCH 0/3] cxl: documentation fixes Bagas Sanjaya
2022-08-04 7:54 ` [PATCH 1/3] cxl/regions: add padding for cxl_rr_ep_add nested lists Bagas Sanjaya
2022-08-04 9:15 ` Jonathan Cameron
2022-08-04 7:54 ` [PATCH 2/3] cxl/region: describe targets and nr_targets members of cxl_region_params Bagas Sanjaya
2022-08-04 13:35 ` Jonathan Cameron [this message]
2022-08-04 7:54 ` [PATCH 3/3] Documentation: cxl: remove dangling kernel-doc reference Bagas Sanjaya
2022-08-04 13:32 ` Jonathan Cameron
2022-08-05 0:48 ` [PATCH 0/3] cxl: documentation fixes Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220804143540.000041c2@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=bagasdotme@gmail.com \
--cc=bwidawsk@kernel.org \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).