From: "José Expósito" <jose.exposito89@gmail.com>
To: "Michał Winiarski" <michal.winiarski@intel.com>
Cc: dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Maxime Ripard <mripard@kernel.org>,
David Gow <davidgow@google.com>,
Javier Martinez Canillas <javierm@redhat.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed
Date: Wed, 7 Sep 2022 19:12:01 +0200 [thread overview]
Message-ID: <20220907171201.GA4529@elementary> (raw)
In-Reply-To: <20220905184711.391022-1-michal.winiarski@intel.com>
Hi Michał,
On Mon, Sep 05, 2022 at 08:47:11PM +0200, Michał Winiarski wrote:
> When built for UML, KUnit provides virtio/PCI, which means that the
> DMA/IOMEM UML emulation needed by DRM is already present and does not
> need to be manually added with --kconfig_add.
>
> References: commit 6fc3a8636a7b ("kunit: tool: Enable virtio/PCI by default on UML")
> Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
> ---
> Documentation/gpu/drm-internals.rst | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/Documentation/gpu/drm-internals.rst b/Documentation/gpu/drm-internals.rst
> index 5fd20a306718..c264a9587d21 100644
> --- a/Documentation/gpu/drm-internals.rst
> +++ b/Documentation/gpu/drm-internals.rst
> @@ -228,16 +228,11 @@ follows:
>
> .. code-block:: bash
>
> - $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests \
> - --kconfig_add CONFIG_VIRTIO_UML=y \
> - --kconfig_add CONFIG_UML_PCI_OVER_VIRTIO=y
> + $ ./tools/testing/kunit/kunit.py run --kunitconfig=drivers/gpu/drm/tests
>
> .. note::
> The configuration included in ``.kunitconfig`` should be as generic as
> possible.
> - ``CONFIG_VIRTIO_UML`` and ``CONFIG_UML_PCI_OVER_VIRTIO`` are not
> - included in it because they are only required for User Mode Linux.
> -
>
> Legacy Support Code
> ===================
> --
> 2.37.3
>
Thanks for the patch. This was in my ToDo list and I was waiting until
6fc3a8636a7b was merged in the DRM tree, but since you already fixed it
I can mark it as done.
Thanks!
prev parent reply other threads:[~2022-09-07 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 18:47 [PATCH] drm/doc: Custom Kconfig for KUnit is no longer needed Michał Winiarski
2022-09-06 1:37 ` Bagas Sanjaya
2022-09-06 8:12 ` Michał Winiarski
2022-09-06 8:53 ` Jonathan Corbet
2022-09-07 17:12 ` José Expósito [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220907171201.GA4529@elementary \
--to=jose.exposito89@gmail.com \
--cc=airlied@linux.ie \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=davidgow@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.winiarski@intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).