From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13313C07E9D for ; Sat, 24 Sep 2022 04:25:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233053AbiIXEZj (ORCPT ); Sat, 24 Sep 2022 00:25:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231701AbiIXEZi (ORCPT ); Sat, 24 Sep 2022 00:25:38 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 452D7193DA for ; Fri, 23 Sep 2022 21:25:02 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id go6so1741173pjb.2 for ; Fri, 23 Sep 2022 21:25:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date; bh=SryvsTQwltO56wFoDvYodwqQ1nJOEHCTIO0SJE5NltI=; b=ObuYdtRhhEO7gwpcaf1j2KjwMFpw8F5W/TLQdvkECdKCrvzl5XhjxOIVWCFrX9Pum/ Ie1/G7co8F4srMEufyH74VkvfDtJCE9BD7NEc4LuOBhrmD6dRNV5H/A7IBng9Yt9p6wM dJpmNomGeevmMKL2gfWwYGOAY0fBJgpMugGrA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date; bh=SryvsTQwltO56wFoDvYodwqQ1nJOEHCTIO0SJE5NltI=; b=U2W3uHnhgcz0w1jVT/zSpZ6fIuleF+r24aqO5bBKAwcgjVbSrmvnNn3crSNzLnib58 HC6cHaKjyHBSggpysGH8WhTdD74Y8biamD2cXmasbpFp+WlgTyfRXcnp8WDHkyRF1GUp 378DxYDvBR2CJfCE6drKec/55/OpT+jLjwJFUCKuea+Ml6Wgrj1VyEVHVsgzUGB43rR/ YEMp7VLrEk5MgXoXwZEwd6gDC/qNGJEsCuvb/VqLtQvLil1/iHTiTJopprqUDT8llZpH giD+qCsVAbM6bwJeAt+DD34AxbzsDJO7Ouwl2laA9z/T3mMJJGP+ErKkWKMwZHKomzlP 7khQ== X-Gm-Message-State: ACrzQf1jPBazGgGOihColHtmZ3RygRJzg1B0woy+/I+DhT/TUTYn88TD 3c0u/C09UU52UITEj5dOlnZa1A== X-Google-Smtp-Source: AMsMyM7T9m312Yujg1sI+sfc1mrgJtRTD4FRf7qTOYqqZkubbh1ByTieKeWf7zSDNEfsqZiDd94wDg== X-Received: by 2002:a17:90b:38cb:b0:203:100:bb53 with SMTP id nn11-20020a17090b38cb00b002030100bb53mr13412364pjb.107.1663993501436; Fri, 23 Sep 2022 21:25:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b20-20020a630c14000000b0043ab80adf63sm6323708pgl.36.2022.09.23.21.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Sep 2022 21:25:00 -0700 (PDT) Date: Fri, 23 Sep 2022 21:24:59 -0700 From: Kees Cook To: Akira Yokosawa Cc: Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-doc@vger.kernel.org, Jonathan Corbet Subject: Re: [PATCH] string: Rewrite and add more kern-doc for the str*() functions Message-ID: <202209232124.F8233E7@keescook> References: <20220922062817.2283352-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Sat, Sep 24, 2022 at 11:31:16AM +0900, Akira Yokosawa wrote: > Hi Kees, > > On Wed, 21 Sep 2022 23:28:17 -0700, Kees Cook wrote: > > While there were varying degrees of kern-doc for various str*()-family > > functions, many needed updating and clarification, or to just be > > entirely written. Update (and relocate) existing kern-doc and add missing > > functions, sadly shaking my head at how many times I have written "Do > > not use this function". Include the results in the core kernel API doc. > > > > Signed-off-by: Kees Cook > > --- > > Follow up to https://lore.kernel.org/lkml/20220902223507.2537469-1-keescook@chromium.org > > Note that this is on top of my recent fortify-string.h series: > > https://lore.kernel.org/lkml/20220920192202.190793-1-keescook@chromium.org/ > I wanted to test this change, but I've not able to find a good commit > where the fortify-string.h series and this one can be applied cleanly. > > Would you mind creating a topic branch somewhere on your git tree > and sharing it? Sure! It's part of my devel/hardening branch: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=devel/hardening Thanks for taking a look! -- Kees Cook