From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Bagas Sanjaya <bagasdotme@gmail.com>,
linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH v4 3/4] Documentation: rs485: Mention uart_get_rs485_mode()
Date: Thu, 29 Sep 2022 12:31:47 +0300 [thread overview]
Message-ID: <20220929093148.9468-4-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20220929093148.9468-1-ilpo.jarvinen@linux.intel.com>
Add to rs485 documentation that serial core prepares the struct
serial_rs485 when uart_get_rs485_mode() is called. Remove the wrong
claim that the driver must fill it by itself.
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
Documentation/driver-api/serial/serial-rs485.rst | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/driver-api/serial/serial-rs485.rst b/Documentation/driver-api/serial/serial-rs485.rst
index 513758a702a6..ee34c8e1e56e 100644
--- a/Documentation/driver-api/serial/serial-rs485.rst
+++ b/Documentation/driver-api/serial/serial-rs485.rst
@@ -34,8 +34,9 @@ RS485 Serial Communications
parameters in the platform data and in ioctls.
The device tree can also provide RS485 boot time parameters
- [#DT-bindings]_. The driver is in charge of filling this data structure
- from the values given by the device tree.
+ [#DT-bindings]_. The serial core fills the struct serial_rs485 from the
+ values given by the device tree when the driver calls
+ uart_get_rs485_mode().
Any driver for devices capable of working both as RS232 and RS485 should
implement the rs485_config callback and provide rs485_supported in the
@@ -48,7 +49,7 @@ RS485 Serial Communications
serial_rs485 structure matching to the current configuration.
.. kernel-doc:: include/uapi/linux/serial.h
- :identifiers: serial_rs485
+ :identifiers: serial_rs485 uart_get_rs485_mode
4. Usage from user-level
========================
--
2.30.2
next prev parent reply other threads:[~2022-09-29 9:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 9:31 [PATCH v4 0/4] serial: RS485 kerneldoc/documentation improvements Ilpo Järvinen
2022-09-29 9:31 ` [PATCH v4 1/4] serial: Convert serial_rs485 to kernel doc Ilpo Järvinen
2022-09-30 9:27 ` Bagas Sanjaya
2022-09-29 9:31 ` [PATCH v4 2/4] Documentation: rs485: Link reference properly Ilpo Järvinen
2022-09-29 9:31 ` Ilpo Järvinen [this message]
2022-09-29 9:31 ` [PATCH v4 4/4] Documentation: rs485: Fix struct referencing Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220929093148.9468-4-ilpo.jarvinen@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).