From: Steven Rostedt <rostedt@goodmis.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] docs: ftrace: Correct access mode
Date: Sat, 8 Oct 2022 16:19:28 -0400 [thread overview]
Message-ID: <20221008161928.7098b068@rorschach.local.home> (raw)
In-Reply-To: <20221008083250.3160-1-leo.yan@linaro.org>
On Sat, 8 Oct 2022 08:32:50 +0000
Leo Yan <leo.yan@linaro.org> wrote:
> The documentation gives an example for opening trace marker with
> write-only mode, but the flag WR_ONLY is not defined by glibc.
>
> Use O_WRONLY to replace it.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> Documentation/trace/ftrace.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> index b37dc19e4d40..60bceb018d6a 100644
> --- a/Documentation/trace/ftrace.rst
> +++ b/Documentation/trace/ftrace.rst
> @@ -564,7 +564,7 @@ of ftrace. Here is a list of some of the key files:
>
> start::
>
> - trace_fd = open("trace_marker", WR_ONLY);
> + trace_fd = open("trace_marker", O_WRONLY);
Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
-- Steve
>
> Note: Writing into the trace_marker file can also initiate triggers
> that are written into /sys/kernel/tracing/events/ftrace/print/trigger
next prev parent reply other threads:[~2022-10-08 20:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 8:32 [PATCH] docs: ftrace: Correct access mode Leo Yan
2022-10-08 20:19 ` Steven Rostedt [this message]
2022-10-10 18:51 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221008161928.7098b068@rorschach.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=leo.yan@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox