From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, saeedm@nvidia.com, corbet@lwn.net,
michael.chan@broadcom.com, huangguangbin2@huawei.com,
chenhao288@hisilicon.com, moshet@nvidia.com,
linux@rempel-privat.de, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next] ethtool: linkstate: add a statistic for PHY down events
Date: Wed, 26 Oct 2022 09:10:15 -0700 [thread overview]
Message-ID: <20221026091015.643b3e8f@kernel.org> (raw)
In-Reply-To: <Y1klvBsXfEXd4y8M@lunn.ch>
On Wed, 26 Oct 2022 14:19:08 +0200 Andrew Lunn wrote:
> You might want to consider a generic implementation in phylib.
Would bumping a counter in phy_link_down() be suitable?
I'm slightly unsure about the cable test behavior but
I think increments during cable tests are quite fair.
> You should then have over 60 drivers implementing this, enough
> momentum it might actually get used.
Depends on your definition of "get used", I can guarantee it will
get used according to my definition :)
next prev parent reply other threads:[~2022-10-26 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 2:09 [PATCH net-next] ethtool: linkstate: add a statistic for PHY down events Jakub Kicinski
2022-10-26 7:40 ` Oleksij Rempel
2022-10-26 12:58 ` Andrew Lunn
2022-10-26 16:11 ` Jakub Kicinski
2022-10-26 12:19 ` Andrew Lunn
2022-10-26 16:10 ` Jakub Kicinski [this message]
2022-10-26 21:32 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221026091015.643b3e8f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=chenhao288@hisilicon.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=huangguangbin2@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=michael.chan@broadcom.com \
--cc=moshet@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).