From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: наб <nabijaczleweli@nabijaczleweli.xyz>
Cc: Jonathan Corbet <corbet@lwn.net>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Alex Shi <alexs@kernel.org>, Yanteng Si <siyanteng@loongson.cn>,
Hu Haowen <src.res@email.cn>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc-tw-discuss@lists.sourceforge.net,
linux-mips@vger.kernel.org
Subject: Re: [PATCH v2 07/15] MIPS: IP27: clean out sn/nmi.h
Date: Tue, 8 Nov 2022 17:41:39 +0100 [thread overview]
Message-ID: <20221108164139.GA3277@alpha.franken.de> (raw)
In-Reply-To: <20221108153820.fp5du7p7zr7pc7cs@tarta.nabijaczleweli.xyz>
On Tue, Nov 08, 2022 at 04:38:20PM +0100, наб wrote:
> On Fri, Nov 04, 2022 at 03:50:02PM +0100, Thomas Bogendoerfer wrote:
> > On Wed, Nov 02, 2022 at 12:05:30AM +0100, Ahelenia Ziemiańska wrote:
> > > The only user is arch/mips/sgi-ip27/ip27-nmi.c; this file was imported
> > > wholesale in 2.3.99pre9-1, and received only whitespace updates since
> > > then.
> > >
> > > NMI_MAGIC isn't a magic number; it's unclear if it's actually used by
> > > the firmware in some capacity or if it's a holdover from copying the SGI
> > > code, but in the former case it's API and in the latter it's dead cruft.
> >
> > it's used by firmware and Linux code to register the NMI exception
> > handler.
> Great, I'll put that in the message.
>
> > Please leave arch/mips/include/asm/sn/nmi.h untouched as
> > it's documents firmware NMI handler usage (even when we don't use it, yet).
> "Yet".
> This file appeared in 2.3.99pre9-1, and hasn't changed since.
> I removed hard-coded assembly struct offsets, which we'll never use,
> because we /haven't/ used them, and this part is implemented in C.
> This file's my age, and these parts have been dead for just as long.
>
> Yet.
it might be never used, but what's the problem with them ? Those
files came from IRIX and "document" the firmware interface. And me
as the MIPS maintainer wants to keep it there.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
next prev parent reply other threads:[~2022-11-08 16:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 23:04 [PATCH v2 00/15] magic-number.rst funeral rites Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 01/15] hamradio: baycom: remove BAYCOM_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 02/15] hamradio: yam: remove YAM_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 03/15] pcmcia: synclink_cs: remove MGSLPC_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 05/15] coda: remove CODA_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 06/15] Documentation: remove PG_MAGIC (not a magic number) Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 07/15] MIPS: IP27: clean out sn/nmi.h Ahelenia Ziemiańska
2022-11-04 14:50 ` Thomas Bogendoerfer
2022-11-08 15:38 ` наб
2022-11-08 16:41 ` Thomas Bogendoerfer [this message]
2022-11-01 23:05 ` [PATCH v2 08/15] MIPS: IP27: remove KV_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 09/15] x86/APM: remove APM_BIOS_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 10/15] scsi: acorn: remove QUEUE_MAGIC_{FREE,USED} Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 11/15] hdlcdrv: remove HDLCDRV_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 12/15] drivers: net: slip: remove SLIP_MAGIC Ahelenia Ziemiańska
2022-11-01 23:05 ` [PATCH v2 13/15] fcntl: remove FASYNC_MAGIC Ahelenia Ziemiańska
2022-11-01 23:06 ` [PATCH v2 14/15] scsi: ncr53c8xx: replace CCB_MAGIC with bool busy Ahelenia Ziemiańska
2022-11-04 19:57 ` James Bottomley
2022-11-09 19:40 ` Ahelenia Ziemiańska
2022-11-01 23:06 ` [PATCH v2 15/15] Documentation: remove magic-number.rst Ahelenia Ziemiańska
2022-11-04 18:35 ` [PATCH v2 00/15] magic-number.rst funeral rites Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221108164139.GA3277@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=alexs@kernel.org \
--cc=corbet@lwn.net \
--cc=federico.vaga@vaga.pv.it \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc-tw-discuss@lists.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=siyanteng@loongson.cn \
--cc=src.res@email.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).