From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BD10C433FE for ; Thu, 10 Nov 2022 00:02:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231863AbiKJACJ (ORCPT ); Wed, 9 Nov 2022 19:02:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229802AbiKJACI (ORCPT ); Wed, 9 Nov 2022 19:02:08 -0500 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8130A222B1 for ; Wed, 9 Nov 2022 16:02:07 -0800 (PST) Received: by mail-pj1-x102d.google.com with SMTP id k5so308731pjo.5 for ; Wed, 09 Nov 2022 16:02:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p7Daps8F455XQYwxt4zsfNkYk/NEUbSHg8y4fLlQGlw=; b=de0Un6NHJwrYjGdsd6Hymr0RokpmscUp2nh2NVTZj16/sDwr/QqPVU7saLLLzVMrUX YtE4r6ZyFaxxplkamm8PKWRaExJTGGKPuJBAXRgwy0dgvQ057uPnLb+EjXckvxx0bcwH LJ7COv565ogXqugWgr1BeSviJdw6iyuPBpUDs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p7Daps8F455XQYwxt4zsfNkYk/NEUbSHg8y4fLlQGlw=; b=alGkm5pMOhsfeyxNSNbL5YmBdR58lylmQh5HNQAzrjkb0SY9R9TkF0jvyEFDC/fQTQ 9q8ymsjOe6yhTnBesOCkTdNHzcnZGzymT/xHqFnIS70GB0ag0BW1jyLMosKHt/C6uPmp 47Z12U5GzMxICbF8zcHZHSRBAUDeL/CgQQDuo/3HHa99rD95rAmdOid14l92GjN9n1B0 CY9u5xRHcZ9ZVkOj7pg52ShqLbgjmbZRunRp8/61HBMpA7zn6opz9j5e69QrBnRAWiJi oG6xJgtyF5jzbFLG4etGZR9nnsEW/zVJ/o7hsNHktc6Acv26zoKfNSKARmmeQ5AG8pKW A4Mg== X-Gm-Message-State: ACrzQf0u5RIvxPOP4XQUVzV3VPAueiDNOfEjBwIHqQASFfkOs/070fT3 cwjLzNUB0sTLDk/dzwAaoxAHjQ== X-Google-Smtp-Source: AMsMyM5bthcPbXOxkKa6K+tg7fCCiv2SKynZlpoNO+Ox1nGoYBjoLBD79gHYEBB3qUS2rPF4vEcp8g== X-Received: by 2002:a17:90a:f306:b0:213:b191:f3bf with SMTP id ca6-20020a17090af30600b00213b191f3bfmr62515127pjb.237.1668038526964; Wed, 09 Nov 2022 16:02:06 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id i4-20020a056a00004400b005668b26ade0sm8799343pfk.136.2022.11.09.16.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 16:02:06 -0800 (PST) Date: Wed, 9 Nov 2022 16:02:05 -0800 From: Kees Cook To: Bill Wendling Cc: Jann Horn , Petr Mladek , Andrew Morton , tangmeng , "Guilherme G. Piccoli" , Tiezhu Yang , Sebastian Andrzej Siewior , Greg KH , Linus Torvalds , Seth Jenkins , Andy Lutomirski , "Eric W. Biederman" , Arnd Bergmann , Marco Elver , Dmitry Vyukov , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Vincenzo Frascino , Luis Chamberlain , David Gow , "Paul E. McKenney" , Jonathan Corbet , Baolin Wang , "Jason A. Donenfeld" , Eric Biggers , Huang Ying , Anton Vorontsov , Mauro Carvalho Chehab , Laurent Dufour , Rob Herring , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v2 1/6] panic: Separate sysctl logic from CONFIG_SMP Message-ID: <202211091601.E07A8D57@keescook> References: <20221109194404.gonna.558-kees@kernel.org> <20221109200050.3400857-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, Nov 09, 2022 at 01:48:45PM -0800, Bill Wendling wrote: > On Wed, Nov 9, 2022 at 12:01 PM Kees Cook wrote: > > > > In preparation for adding more sysctls directly in kernel/panic.c, split > > CONFIG_SMP from the logic that adds sysctls. > > > > Cc: Petr Mladek > > Cc: Andrew Morton > > Cc: tangmeng > > Cc: "Guilherme G. Piccoli" > > Cc: Tiezhu Yang > > Cc: Sebastian Andrzej Siewior > > Signed-off-by: Kees Cook > > --- > > kernel/panic.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/kernel/panic.c b/kernel/panic.c > > index da323209f583..129936511380 100644 > > --- a/kernel/panic.c > > +++ b/kernel/panic.c > > @@ -75,8 +75,9 @@ ATOMIC_NOTIFIER_HEAD(panic_notifier_list); > > > > EXPORT_SYMBOL(panic_notifier_list); > > > > -#if defined(CONFIG_SMP) && defined(CONFIG_SYSCTL) > > +#if CONFIG_SYSCTL > > Should this be "#ifdef CONFIG_SYSCTL"? > > > static struct ctl_table kern_panic_table[] = { > > +#if defined(CONFIG_SMP) > > nit: This could be "#ifdef CONFIG_SMP" Whoops, yes. Thanks. I'll fix these for v3. -- Kees Cook