From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23CD4C4332F for ; Sun, 20 Nov 2022 20:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229685AbiKTUwK (ORCPT ); Sun, 20 Nov 2022 15:52:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbiKTUwJ (ORCPT ); Sun, 20 Nov 2022 15:52:09 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 761CF2B1A3 for ; Sun, 20 Nov 2022 12:52:08 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id p16so7223804wmc.3 for ; Sun, 20 Nov 2022 12:52:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SG0Aeb3AkNCRdUKmIoyZXLGGCOpWzdo7IiLbJYcybAQ=; b=sVJjVbQ8f6t/SnFDbSP7Uh2ol/fTnLHmcckKbLxA0w2qvSHz+/egSniH/vQEVhRTIQ 1sDT/RoYXRg7mslXE107+QRF2buBDezS/Xde8n/KDizX3G+AHdu/60x2nkWPe99c7j+c niF9Cu+w+rT0bAZh3V8+mQLMGAHGLq3wyWtG7srXCyKm6caQgCRk6IMkLe4zudDiHOjp 7WZrRqFYGJVbA37cA6RcBO8ohnmA6dXrvFPKFrB0XcSNJfPC6mS47AC6tPWx5JAh27KS y/1Cd2RT/4t8mJ0bqBpYBmiAecWftsvwPhHe4ulEET5AuBGNbpzKTOa67vZM7vpJxEaT sKQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SG0Aeb3AkNCRdUKmIoyZXLGGCOpWzdo7IiLbJYcybAQ=; b=frFqQYOqZbdrhQcKtZLuzTSMWWDUM4B13Eq1MJkGJO2Wq7oiFnK6vHQQUY2svYCir4 DBhi9vyeQetUiOGGK2e8zEux2IFrF3wOLOtvJsW/idx7GMtuLZU4Fo7MR1WB8b8T7zYz yrmdSkotNW+YoPZxWddDyoOkHbcr2R3caRqX+SPOifxWDydk8YBhrOFKi4WsTZuES1WF uW4bJSdk575PxsrFa+q0om5Xy8jzqgu3QopmRStyeTY5kfi9lIvZwv9CZ8HE8eW/cAqu +H9nWJSt6beVRzKdxzOeHoUxsj0CiAfypccihkkagRMgNhC8F7VLmiVXuuJyQBHp+AZi sAMQ== X-Gm-Message-State: ANoB5pk38LPa0u1ZbVcBLmvCQAyhzXCZIcU/sP9IAKOUadOuBnOwnN6m lvWhuFTigmpGgXrljXamwEriEg== X-Google-Smtp-Source: AA0mqf7bOvSTYUu/AICcCb4TKkNUK5bJ4iXaEeIUcc2L+EI+6h0HYJGdUl7p/lc5fV8n5firUWmbXQ== X-Received: by 2002:a05:600c:1f0c:b0:3cf:a41d:8418 with SMTP id bd12-20020a05600c1f0c00b003cfa41d8418mr2708337wmb.190.1668977526994; Sun, 20 Nov 2022 12:52:06 -0800 (PST) Received: from airbuntu (host86-130-134-87.range86-130.btcentralplus.com. [86.130.134.87]) by smtp.gmail.com with ESMTPSA id q3-20020adfcd83000000b0022eafed36ebsm9571723wrj.73.2022.11.20.12.52.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Nov 2022 12:52:06 -0800 (PST) Date: Sun, 20 Nov 2022 20:52:05 +0000 From: Qais Yousef To: Bagas Sanjaya Cc: kernel test robot , Ingo Molnar , Peter Zijlstra , Dietmar Eggemann , Vincent Guittot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Lukasz Luba , Xuewen Yan , Wei Wang , Jonathan JMChen , Hank , Paul Bone , Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [PATCH] Documentation: sched: Add a new sched-util-clamp.rst Message-ID: <20221120205205.itjp7ken5hdbtkty@airbuntu> References: <20221113152629.3wbyeejsj5v33rvu@airbuntu> <20221115205547.3f4kzig5r44ipv3b@airbuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 11/16/22 15:36, Bagas Sanjaya wrote: > On Tue, Nov 15, 2022 at 08:55:47PM +0000, Qais Yousef wrote: > > > > 2.1 BUCKETS: > > > > ------------- > > > > > > > > +.. code-block:: c > > > > + > > > > [struct rq] > > > > > > > > -(bottom) (top) > > > > + (bottom) (top) > > > > > > > > - 0 1024 > > > > - | | > > > > - +-----------+-----------+-----------+---- ----+-----------+ > > > > - | Bucket 0 | Bucket 1 | Bucket 2 | ... | Bucket N | > > > > - +-----------+-----------+-----------+---- ----+-----------+ > > > > - : : : > > > > - +- p0 +- p3 +- p4 > > > > - : : > > > > - +- p1 +- p5 > > > > - : > > > > - +- p2 > > > > + 0 1024 > > > > + | | > > > > + +-----------+-----------+-----------+---- ----+-----------+ > > > > + | Bucket 0 | Bucket 1 | Bucket 2 | ... | Bucket N | > > > > + +-----------+-----------+-----------+---- ----+-----------+ > > > > + : : : > > > > + +- p0 +- p3 +- p4 > > > > + : : > > > > + +- p1 +- p5 > > > > + : > > > > + +- p2 > > > > > > The code block above is diagram, isn't it? Thus specifying language for > > > syntax highlighting (in this case ``c``) isn't appropriate. > > > > I could do with a helping hand here actually. I am a text only person but > > trying to follow the new rst docs; but I don't have a clue to be honest. > > > > I did try to find the right directive, but I couldn't find it. What should be > > specified for this diagram? > > Just leave ..code-block:: directive alone or use simpler double colon > (::). The highlighting will not be applied to the code snippet. Leaving ..code-block:: produces this error: sched-util-clamp.rst:172: WARNING: Error in "code-block" directive: 1 argument(s) required, 0 supplied I used :: and it seems to produces the desired results. I tried this first but I think my indentation was broken then which is why it didn't work at the time and I moved to code-block. > > > > > @@ -200,6 +203,8 @@ The rq has a bucket for each uclamp_id: [UCLAMP_MIN, UCLAMP_MAX]. > > > > The range of each bucket is 1024/N. For example for the default value of 5 we > > > > will have 5 buckets, each of which will cover the following range: > > > > > > > > +.. code-block:: c > > > > + > > > > > > Again, why ``c`` syntax highlighting? > > > > This is a C code snippet. What would be better to use? I think I was getting > > errors if I don't specify something. But again; I was touching my way around in > > the dark here trying to figure it out. > > > > Yup, that's the correct language for highlighting. Thanks Bagas! -- Qais Yousef