From: Robert Elliott <elliott@hpe.com>
To: herbert@gondor.apana.org.au, davem@davemloft.net, corbet@lwn.net,
linux-crypto@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Robert Elliott <elliott@hpe.com>
Subject: [PATCH v2 6/8] crypto: x86/ghash - add kernel-doc comments to assembly
Date: Mon, 19 Dec 2022 12:55:53 -0600 [thread overview]
Message-ID: <20221219185555.433233-7-elliott@hpe.com> (raw)
In-Reply-To: <20221219185555.433233-1-elliott@hpe.com>
Add kernel-doc comments for assembly language functions exported to
C glue code.
Signed-off-by: Robert Elliott <elliott@hpe.com>
---
arch/x86/crypto/ghash-clmulni-intel_asm.S | 27 +++++++++++++++++++----
1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/arch/x86/crypto/ghash-clmulni-intel_asm.S b/arch/x86/crypto/ghash-clmulni-intel_asm.S
index 2bf871899920..09cf9271b83a 100644
--- a/arch/x86/crypto/ghash-clmulni-intel_asm.S
+++ b/arch/x86/crypto/ghash-clmulni-intel_asm.S
@@ -88,7 +88,16 @@ SYM_FUNC_START_LOCAL(__clmul_gf128mul_ble)
RET
SYM_FUNC_END(__clmul_gf128mul_ble)
-/* void clmul_ghash_mul(char *dst, const u128 *shash) */
+/**
+ * clmul_ghash_mul - Calculate GHASH final multiplication using x86 PCLMULQDQ instructions
+ * @dst: address of hash value to update (%rdi)
+ * @shash: address of hash context (%rsi)
+ *
+ * This supports 64-bit CPUs.
+ *
+ * Return: none (but @dst is updated)
+ * Prototype: asmlinkage void clmul_ghash_mul(char *dst, const u128 *shash)
+ */
SYM_FUNC_START(clmul_ghash_mul)
FRAME_BEGIN
movups (%rdi), DATA
@@ -102,9 +111,19 @@ SYM_FUNC_START(clmul_ghash_mul)
RET
SYM_FUNC_END(clmul_ghash_mul)
-/*
- * void clmul_ghash_update(char *dst, const char *src, unsigned int srclen,
- * const u128 *shash);
+/**
+ * clmul_ghash_update - Calculate GHASH using x86 PCLMULQDQ instructions
+ * @dst: address of hash value to update (%rdi)
+ * @src: address of data to hash (%rsi)
+ * @srclen: number of bytes in data buffer (%rdx);
+ * function does nothing and returns if below 16
+ * @shash: address of hash context (%rcx)
+ *
+ * This supports 64-bit CPUs.
+ *
+ * Return: none (but @dst is updated)
+ * Prototype: asmlinkage clmul_ghash_update(char *dst, const char *src,
+ * unsigned int srclen, const u128 *shash);
*/
SYM_FUNC_START(clmul_ghash_update)
FRAME_BEGIN
--
2.38.1
next prev parent reply other threads:[~2022-12-19 18:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 6:38 [PATCH 0/8] crypto: kernel-doc for assembly language Robert Elliott
2022-12-15 6:38 ` [PATCH 1/8] crypto: clean up kernel-doc headers Robert Elliott
2022-12-15 6:38 ` [PATCH 2/8] doc: support kernel-doc for asm functions Robert Elliott
2022-12-15 6:38 ` [PATCH 3/8] crypto: x86/sha - add kernel-doc comments to assembly Robert Elliott
2022-12-15 6:38 ` [PATCH 4/8] crypto: x86/crc " Robert Elliott
2022-12-15 6:38 ` [PATCH 5/8] crypto: x86/sm3 " Robert Elliott
2022-12-15 6:38 ` [PATCH 6/8] crypto: x86/ghash " Robert Elliott
2022-12-15 6:38 ` [PATCH 7/8] crypto: x86/blake2s " Robert Elliott
2022-12-15 6:38 ` [PATCH 8/8] crypto: x86/chacha " Robert Elliott
2022-12-19 18:55 ` [PATCH v2 0/8] crypto: kernel-doc for assembly language Robert Elliott
2022-12-19 18:55 ` [PATCH v2 1/8] crypto: clean up kernel-doc headers Robert Elliott
2022-12-19 18:55 ` [PATCH v2 2/8] doc: support kernel-doc for asm functions Robert Elliott
2022-12-19 18:55 ` [PATCH v2 3/8] crypto: x86/sha - add kernel-doc comments to assembly Robert Elliott
2022-12-19 18:55 ` [PATCH v2 4/8] crypto: x86/crc " Robert Elliott
2022-12-19 18:55 ` [PATCH v2 5/8] crypto: x86/sm3 " Robert Elliott
2022-12-19 18:55 ` Robert Elliott [this message]
2022-12-20 6:01 ` [PATCH v2 6/8] crypto: x86/ghash " Eric Biggers
2022-12-19 18:55 ` [PATCH v2 7/8] crypto: x86/blake2s " Robert Elliott
2022-12-19 18:55 ` [PATCH v2 8/8] crypto: x86/chacha " Robert Elliott
2022-12-20 6:05 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219185555.433233-7-elliott@hpe.com \
--to=elliott@hpe.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox