From: Oleg Nesterov <oleg@redhat.com>
To: Gregory Price <gourry.memverge@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
avagin@gmail.com, peterz@infradead.org, luto@kernel.org,
krisman@collabora.com, tglx@linutronix.de, corbet@lwn.net,
shuah@kernel.org, Gregory Price <gregory.price@memverge.com>
Subject: Re: [PATCH 2/2] ptrace,syscall_user_dispatch: checkpoint/restore support for SUD
Date: Thu, 16 Feb 2023 14:57:38 +0100 [thread overview]
Message-ID: <20230216135737.GC5200@redhat.com> (raw)
In-Reply-To: <20230214085215.106708-3-gregory.price@memverge.com>
On 02/14, Gregory Price wrote:
>
> +struct compat_ptrace_sud_config {
> + compat_ulong_t mode;
> + compat_uptr_t selector;
> + compat_ulong_t offset;
> + compat_ulong_t len;
> +};
...
> +int syscall_user_dispatch_get_config(struct task_struct *task, unsigned long size,
> + void __user *data)
> +{
> + struct syscall_user_dispatch *sd = &task->syscall_dispatch;
> +#ifdef CONFIG_COMPAT
> + if (unlikely(in_compat_syscall())) {
> + struct compat_ptrace_sud_config cfg32;
> +
> + if (size != sizeof(struct compat_ptrace_sud_config))
> + return -EINVAL;
> +
Horror ;) why?
See my reply to v9, just make
struct ptrace_sud_config {
__u8 mode;
__u64 selector;
__u64 offset;
__u64 len;
};
Oleg.
next prev parent reply other threads:[~2023-02-16 13:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 8:52 [PATCH 0/2] Checkpoint Support for Syscall User Dispatch Gregory Price
2023-02-14 8:52 ` [PATCH 1/2] syscall_user_dispatch: helper function to operate on given task Gregory Price
2023-02-14 8:52 ` [PATCH 2/2] ptrace,syscall_user_dispatch: checkpoint/restore support for SUD Gregory Price
2023-02-16 13:57 ` Oleg Nesterov [this message]
2023-02-18 10:53 ` Gregory Price
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216135737.GC5200@redhat.com \
--to=oleg@redhat.com \
--cc=avagin@gmail.com \
--cc=corbet@lwn.net \
--cc=gourry.memverge@gmail.com \
--cc=gregory.price@memverge.com \
--cc=krisman@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).