From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Tina Zhang <tina.zhang@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, <iommu@lists.linux.dev>,
Jason Gunthorpe <jgg@nvidia.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Joerg Roedel <joro@8bytes.org>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
"Dave Hansen" <dave.hansen@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
"X86 Kernel" <x86@kernel.org>, <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Peter Zijlstra <peterz@infradead.org>, <corbet@lwn.net>,
<vkoul@kernel.org>, <dmaengine@vger.kernel.org>,
<linux-doc@vger.kernel.org>, Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>,
"David Woodhouse" <dwmw2@infradead.org>,
Raj Ashok <ashok.raj@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>, Yi Liu <yi.l.liu@intel.com>,
"Yu, Fenghua" <fenghua.yu@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v4 3/6] iommu/sva: Stop using ioasid_set for SVA
Date: Thu, 2 Mar 2023 09:23:10 -0800 [thread overview]
Message-ID: <20230302092310.77f97361@jacob-builder> (raw)
In-Reply-To: <43e9711f-042e-eaf9-e091-07db78cad943@intel.com>
Hi Tina,
On Thu, 2 Mar 2023 21:52:42 +0800, Tina Zhang <tina.zhang@intel.com> wrote:
> > if (mm->pasid < min || mm->pasid >= max)
> Here seems not right, since the valid range is defined [min, max].
> Shouldn't the invalid range be:
> if (mm->pasid < min || mm->pasid > max)
yes it is better to be consistent even if we removed the inclusive
requirements in the previous comments.
Thanks,
Jacob
next prev parent reply other threads:[~2023-03-02 17:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 23:56 [PATCH v4 0/6] Remove VT-d virtual command interface and IOASID Jacob Pan
2023-03-01 23:56 ` [PATCH v4 1/6] iommu/vt-d: Remove virtual command interface Jacob Pan
2023-03-01 23:56 ` [PATCH v4 2/6] iommu/sva: Move PASID helpers to sva code Jacob Pan
2023-03-02 9:03 ` Tian, Kevin
2023-03-02 16:47 ` Jacob Pan
2023-03-02 12:21 ` Baolu Lu
2023-03-02 16:54 ` Jacob Pan
2023-03-01 23:56 ` [PATCH v4 3/6] iommu/sva: Stop using ioasid_set for SVA Jacob Pan
2023-03-02 8:58 ` Tian, Kevin
2023-03-02 16:57 ` Jacob Pan
2023-03-02 13:01 ` Baolu Lu
2023-03-02 17:17 ` Jacob Pan
2023-03-03 2:24 ` Baolu Lu
2023-03-03 9:32 ` Jean-Philippe Brucker
2023-03-03 9:57 ` Baolu Lu
2023-03-03 13:15 ` Jason Gunthorpe
2023-03-07 17:42 ` Jacob Pan
2023-03-08 7:32 ` Tian, Kevin
2023-03-07 22:32 ` Jacob Pan
2023-03-08 18:23 ` Jason Gunthorpe
2023-03-11 17:18 ` Fenghua Yu
2023-03-20 14:11 ` Jason Gunthorpe
2023-03-02 13:52 ` Tina Zhang
2023-03-02 17:23 ` Jacob Pan [this message]
2023-03-01 23:56 ` [PATCH v4 4/6] iommu/sva: Use GFP_KERNEL for pasid allocation Jacob Pan
2023-03-02 8:59 ` Tian, Kevin
2023-03-02 13:04 ` Baolu Lu
2023-03-01 23:56 ` [PATCH v4 5/6] iommu/ioasid: Rename INVALID_IOASID Jacob Pan
2023-03-02 1:36 ` Fenghua Yu
2023-03-02 9:00 ` Tian, Kevin
2023-03-02 13:07 ` Baolu Lu
2023-03-01 23:56 ` [PATCH v4 6/6] iommu: Remove ioasid infrastructure Jacob Pan
2023-03-02 9:01 ` Tian, Kevin
2023-03-02 13:08 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302092310.77f97361@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux.dev \
--cc=jean-philippe@linaro.com \
--cc=jgg@nvidia.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=tina.zhang@intel.com \
--cc=vkoul@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).