From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>
Cc: linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org,
ogabbay@kernel.org, dri-devel@lists.freedesktop.org,
quic_ajitpals@quicinc.com, quic_pkanojiy@quicinc.com,
quic_carlv@quicinc.com, jacek.lawrynowicz@linux.intel.com
Subject: Re: [PATCH v2 3/8] accel/qaic: Add MHI controller
Date: Fri, 3 Mar 2023 14:57:35 +0100 [thread overview]
Message-ID: <20230303135735.GG3963532@linux.intel.com> (raw)
In-Reply-To: <0f2959e3-8d9e-b603-1317-0d348263f90c@quicinc.com>
On Wed, Mar 01, 2023 at 09:09:57AM -0700, Jeffrey Hugo wrote:
> On 2/28/2023 4:52 AM, Stanislaw Gruszka wrote:
> > On Mon, Feb 06, 2023 at 08:41:40AM -0700, Jeffrey Hugo wrote:
> > > + mhi_cntl = kzalloc(sizeof(*mhi_cntl), GFP_KERNEL);
> > [snip]
> > > + mhi_cntl->irq = kmalloc(sizeof(*mhi_cntl->irq), GFP_KERNEL);
> >
> > I recommend usage of devm_kzalloc(), devm_kmalloc() for those
> > to simplify error and exit paths.
>
> When this was written, I didn't want to pass the struct device to the
> mhi_controller just for the purpose of using devm_*. Today, I'm thinking
> that is not the end of the world, and devm has advantages. Will change.
If already available &pci_dev->dev can not be used in devm_ due to
different life times of pci_dev->dev and mhi_cntl, I don't think change
would be justifiable and kmalloc/kzalloc should stay.
Regards
Stanislaw
next prev parent reply other threads:[~2023-03-03 13:57 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 15:41 [PATCH v2 0/8] QAIC accel driver Jeffrey Hugo
2023-02-06 15:41 ` [PATCH v2 1/8] accel/qaic: Add documentation for AIC100 accelerator driver Jeffrey Hugo
2023-02-14 11:08 ` Jacek Lawrynowicz
2023-02-15 15:41 ` Jeffrey Hugo
2023-02-16 14:18 ` Jacek Lawrynowicz
2023-02-16 15:20 ` Jeffrey Hugo
2023-02-06 15:41 ` [PATCH v2 2/8] accel/qaic: Add uapi and core driver file Jeffrey Hugo
2023-02-16 14:13 ` Jacek Lawrynowicz
2023-02-17 18:15 ` Jeffrey Hugo
2023-02-22 15:52 ` Dafna Hirschfeld
2023-02-24 21:21 ` Jeffrey Hugo
2023-03-01 19:46 ` Jeffrey Hugo
2023-02-06 15:41 ` [PATCH v2 3/8] accel/qaic: Add MHI controller Jeffrey Hugo
2023-02-28 11:52 ` Stanislaw Gruszka
2023-03-01 16:09 ` Jeffrey Hugo
2023-03-03 13:57 ` Stanislaw Gruszka [this message]
2023-02-06 15:41 ` [PATCH v2 4/8] accel/qaic: Add control path Jeffrey Hugo
2023-03-01 13:18 ` Stanislaw Gruszka
2023-03-01 17:02 ` Jeffrey Hugo
2023-02-06 15:41 ` [PATCH v2 5/8] accel/qaic: Add datapath Jeffrey Hugo
2023-02-24 15:25 ` Stanislaw Gruszka
2023-02-24 19:36 ` Jeffrey Hugo
2023-02-27 17:14 ` Stanislaw Gruszka
2023-03-01 16:08 ` Jeffrey Hugo
2023-03-01 17:05 ` Stanislaw Gruszka
2023-03-01 18:14 ` Jeffrey Hugo
2023-03-03 13:49 ` Stanislaw Gruszka
2023-02-06 15:41 ` [PATCH v2 6/8] accel/qaic: Add mhi_qaic_cntl Jeffrey Hugo
2023-03-01 13:19 ` Stanislaw Gruszka
2023-02-06 15:41 ` [PATCH v2 7/8] accel/qaic: Add qaic driver to the build system Jeffrey Hugo
2023-03-01 13:02 ` Stanislaw Gruszka
2023-03-01 16:10 ` Jeffrey Hugo
2023-02-06 15:41 ` [PATCH v2 8/8] MAINTAINERS: Add entry for QAIC driver Jeffrey Hugo
2023-03-01 13:03 ` Stanislaw Gruszka
2023-03-01 16:15 ` Jeffrey Hugo
2023-02-08 22:01 ` [PATCH v2 0/8] QAIC accel driver Jeffrey Hugo
2023-02-17 16:14 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303135735.GG3963532@linux.intel.com \
--to=stanislaw.gruszka@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=ogabbay@kernel.org \
--cc=quic_ajitpals@quicinc.com \
--cc=quic_carlv@quicinc.com \
--cc=quic_jhugo@quicinc.com \
--cc=quic_pkanojiy@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).