From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A38D3C7618E for ; Mon, 20 Mar 2023 19:05:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229959AbjCTTF3 (ORCPT ); Mon, 20 Mar 2023 15:05:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230345AbjCTTEH (ORCPT ); Mon, 20 Mar 2023 15:04:07 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B519E3A4EB; Mon, 20 Mar 2023 11:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679338582; x=1710874582; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5U1pqEnYI3Q80e7Obrp6GUJ1jNRTk8Hz1ySQDnWY03M=; b=AEdh2RN+ny3Xk1m615XJdpjtbERdANZcGmM5AWsrqKf4lOULBRApuaFs JqKjIJC3RxI5ZoztesMLzSbnPqv7xMzmUxYBcqoV8/6ih13JJJhin1K7Z F4qZA4tSr4ISwJkbVZr8dAdbjsbNHr8Ruc2xjqwTPMJlto4mICxTJl+bV stXGbvKSP9qzx3E9LJpsOQKeQZnZbi4xpaRJRpo/pTpLgdC4isakpaUGc o2erVCvS4G+gsPX6aeRod+BjjTPetDhTNo8oEpqjSxGqvZY8QwA7Je3um DzvGZiAGQbMGjYV5wBGNQBYVLUhF4E52MKsoSFDj/L2W1zp3rn7iM3dVB w==; X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="366473785" X-IronPort-AV: E=Sophos;i="5.98,276,1673942400"; d="scan'208";a="366473785" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 11:55:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10655"; a="927076481" X-IronPort-AV: E=Sophos;i="5.98,276,1673942400"; d="scan'208";a="927076481" Received: from srinivas-otcpl-7600.jf.intel.com (HELO jacob-builder.jf.intel.com) ([10.54.39.106]) by fmsmga006.fm.intel.com with ESMTP; 20 Mar 2023 11:55:19 -0700 From: Jacob Pan To: LKML , iommu@lists.linux.dev, Jason Gunthorpe , "Lu Baolu" , Joerg Roedel , Jean-Philippe Brucker , "Robin Murphy" , Dave Hansen , Thomas Gleixner , X86 Kernel , bp@alien8.de, "H. Peter Anvin" , Peter Zijlstra , corbet@lwn.net, vkoul@kernel.org, dmaengine@vger.kernel.org, linux-doc@vger.kernel.org Cc: "Will Deacon" , David Woodhouse , Raj Ashok , "Tian, Kevin" , Yi Liu , "Yu, Fenghua" , Dave Jiang , Kirill Shutemov , Tony Luck , Jacob Pan Subject: [PATCH v7 5/7] iommu/sva: Use GFP_KERNEL for pasid allocation Date: Mon, 20 Mar 2023 11:59:08 -0700 Message-Id: <20230320185910.2643260-6-jacob.jun.pan@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230320185910.2643260-1-jacob.jun.pan@linux.intel.com> References: <20230320185910.2643260-1-jacob.jun.pan@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org We’re not using spinlock-protected IOASID allocation anymore, there’s no need for GFP_ATOMIC. Reviewed-by: Kevin Tian Reviewed-by: Lu Baolu Reviewed-by: Jason Gunthorpe Signed-off-by: Jacob Pan --- drivers/iommu/iommu-sva.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/iommu-sva.c b/drivers/iommu/iommu-sva.c index 48e8a15ddc9b..c434b95dc8eb 100644 --- a/drivers/iommu/iommu-sva.c +++ b/drivers/iommu/iommu-sva.c @@ -28,8 +28,8 @@ static int iommu_sva_alloc_pasid(struct mm_struct *mm, ioasid_t min, ioasid_t ma goto out; } - ret = ida_alloc_range(&iommu_global_pasid_ida, min, max, GFP_ATOMIC); - if (ret < 0) + ret = ida_alloc_range(&iommu_global_pasid_ida, min, max, GFP_KERNEL); + if (ret < min) goto out; mm->pasid = ret; ret = 0; -- 2.25.1