From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0896DC77B71 for ; Sun, 9 Apr 2023 08:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229531AbjDIIVf (ORCPT ); Sun, 9 Apr 2023 04:21:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229527AbjDIIVe (ORCPT ); Sun, 9 Apr 2023 04:21:34 -0400 Received: from mout02.posteo.de (mout02.posteo.de [185.67.36.66]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B17D45B80 for ; Sun, 9 Apr 2023 01:21:32 -0700 (PDT) Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C95712401B9 for ; Sun, 9 Apr 2023 10:21:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681028489; bh=GCmo/FQZEbl3ShLJvIwU3fxDcrVQZl3kl6EFP8KaIFc=; h=Date:From:To:Cc:Subject:From; b=Caf1SSvgMuXeYpAY5NXoJcSW/DiduWlRF7Bm5M8X3AE3VK+hU3Ib3EZYWatrGRd9d hU0/cOD7ET8SMU2+DLk17dFFzv1hrUfgy0Bax1G+hqhb9tCYqW0Pbpj/3ALnAZEtBq B1V0jf2KyKj1suPHOS1nmHTyGFys4XOZB6L6oAqouycgkMElq1TeRmuFRiVd/sWHsP x0JVTTDepAAX2XyI0JMlZ6fsVIFC1hh0O2lw9e/P6nV9KUNC3NpEBZ85PtaXqPU1nr rx+KvREciQJ3SSOD5AoBMnPsDx4f1p1ajoU5JpiE1wRXhTtiT87pqoAJrNpnl0DsQU sqQQk9gm7S7rw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4PvQ6k2vpXz6tvw; Sun, 9 Apr 2023 10:21:18 +0200 (CEST) Date: Sun, 9 Apr 2023 08:21:17 +0000 From: Wilken Gottwalt To: Krzysztof Kozlowski Cc: Jean Delvare , Guenter Roeck , Jonathan Corbet , Oded Gabbay , Michael Hennerich , Aleksa Savic , Jack Doan , Nuno =?ISO-8859-1?Q?S=E1?= , Marius Zachmann , Pali =?ISO-8859-1?Q?Roh=E1r?= , Jean-Marie Verdun , Nick Hawkins , Xu Yilun , Tom Rix , Clemens Ladisch , Rudolf Marek , Charles Keepax , Richard Fitzgerald , Ibrahim Tilki , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Jonas Malaco , Aleksandr Mezin , Derek John Clark , =?ISO-8859-1?Q?Joaqu=EDn?= Ignacio =?ISO-8859-1?Q?Aramend=EDa?= , Iwona Winiarska , Florian Fainelli , Broadcom internal kernel review list , Hans de Goede , Michael Walle , Lars Povlsen , Steen Hegelund , Daniel Machon , UNGLinuxDriver@microchip.com, Agathe Porte , Eric Tremblay , Robert Marko , Luka Perkov , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, patches@opensource.cirrus.com, openbmc@lists.ozlabs.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 12/68] hwmon: corsair: constify pointers to hwmon_channel_info Message-ID: <20230409102117.6fcdc42f@posteo.net> In-Reply-To: <20230406203103.3011503-13-krzysztof.kozlowski@linaro.org> References: <20230406203103.3011503-1-krzysztof.kozlowski@linaro.org> <20230406203103.3011503-13-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Thu, 6 Apr 2023 22:30:07 +0200 Krzysztof Kozlowski wrote: > diff --git a/drivers/hwmon/corsair-psu.c b/drivers/hwmon/corsair-psu.c > index 2210aa62e3d0..dc24c566d08b 100644 > --- a/drivers/hwmon/corsair-psu.c > +++ b/drivers/hwmon/corsair-psu.c > @@ -571,7 +571,7 @@ static const struct hwmon_ops corsairpsu_hwmon_ops = { > .read_string = corsairpsu_hwmon_ops_read_string, > }; > > -static const struct hwmon_channel_info *corsairpsu_info[] = { > +static const struct hwmon_channel_info * const corsairpsu_info[] = { > HWMON_CHANNEL_INFO(chip, > HWMON_C_REGISTER_TZ), > HWMON_CHANNEL_INFO(temp, Wait a minute. Can you at least match it to the coding style of the driver? A lot of work went into it to keep it consistent. greetings, Will