From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEDFEC77B75 for ; Fri, 21 Apr 2023 10:46:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230335AbjDUKqb (ORCPT ); Fri, 21 Apr 2023 06:46:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229818AbjDUKqa (ORCPT ); Fri, 21 Apr 2023 06:46:30 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06B9E83FC; Fri, 21 Apr 2023 03:46:28 -0700 (PDT) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by madras.collabora.co.uk (Postfix) with ESMTPSA id 11EA96602040; Fri, 21 Apr 2023 11:46:26 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1682073986; bh=xy1oqjU5V/MfMlLIxJBwQthAmE3+07DxTdM+2r5CRK4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Jjamna4sOjLQkH1nkuIHUE36adS3B1KZwwMxTmygRn+u3/pxkEYo1F5PkmJVw4239 wJ2unj8E4sgzv5F/dTBIm4We4BM1YRFVftcf1/unkDQWK2Gd8rlwkOk9isIcl8ZU4K u3XVV6sZQ+x6LNMVcVXbvfWEV7n0cWBzE/lFdNDolnKXKo1R0RgZY1KEKNYJjymDZe 1pjNjYuBEHtQJtRZME2qyikHAFFiWNiovamiotKiNxWQ1hFWpN/6yOaGatSU0+IjMt oBZ1VO0ap3BM0VFBCdynQBNuj87otIdpOiix9tBW/8hGrk0GbKGltZP8Kp2AIPgw2M F57uTnKdV+DXQ== Date: Fri, 21 Apr 2023 12:46:22 +0200 From: Boris Brezillon To: Danilo Krummrich Cc: airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net, dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Airlie , donald.robson@imgtec.com Subject: Re: [PATCH drm-next v3 04/15] drm: manager to keep track of GPUs VA mappings Message-ID: <20230421124622.6386cd60@collabora.com> In-Reply-To: <20230404012741.116502-5-dakr@redhat.com> References: <20230404012741.116502-1-dakr@redhat.com> <20230404012741.116502-5-dakr@redhat.com> Organization: Collabora X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, 4 Apr 2023 03:27:30 +0200 Danilo Krummrich wrote: > +/** > + * drm_gpuva_prealloc_create - creates a preallocated node to store a > + * &drm_gpuva entry. > + * > + * Returns: the &drm_gpuva_prealloc object on success, NULL on failure > + */ > +struct drm_gpuva_prealloc * > +drm_gpuva_prealloc_create(void) > +{ > + struct drm_gpuva_prealloc *pa; > + > + pa = kzalloc(sizeof(*pa), GFP_KERNEL); > + if (!pa) > + return NULL; > + > + if (mas_preallocate(&pa->mas, GFP_KERNEL)) { mas_preallocate() needs a valid tree field to calculate the number of nodes to pre-allocate. I guess we're missing a MA_STATE_INIT() here, and we need to pass a gpuva_mgr object to this helper. > + kfree(pa); > + return NULL; > + } > + > + return pa; > +} > +EXPORT_SYMBOL(drm_gpuva_prealloc_create);