From: Steven Rostedt <rostedt@goodmis.org>
To: Alan Maguire <alan.maguire@oracle.com>
Cc: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
corbet@lwn.net, shuah@kernel.org, linux-kernel@vger.kernel.org,
linux-trace-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH tracing 0/3] tracing: support > 8 byte filter predicates
Date: Tue, 25 Apr 2023 13:20:28 -0400 [thread overview]
Message-ID: <20230425132028.7d16e04c@gandalf.local.home> (raw)
In-Reply-To: <9c4cebb7-514c-f7fd-1f95-50837460eb66@oracle.com>
On Tue, 25 Apr 2023 18:15:03 +0100
Alan Maguire <alan.maguire@oracle.com> wrote:
> that's a great idea; what would be the most consistent ftrace syntax
> for this do you think? I noticed that hist triggers append a modifier
> to the field name so would something like
>
> "dst.ipv6 == ::1"
Yeah, I think just having ":" in the name without quotes can help the filter
know that it's a ipv6 id.
Hmm, although we may want to do the same for mac addresses. But we can
determine the difference by the field size. If it's 6 bytes, it's a mac, if
it's 128 bits, then ipv6.
-- Steve
next prev parent reply other threads:[~2023-04-25 17:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 9:16 [PATCH tracing 0/3] tracing: support > 8 byte filter predicates Alan Maguire
2023-04-25 9:16 ` [PATCH tracing 1/3] tracing: support > 8 byte array " Alan Maguire
2023-04-25 10:58 ` kernel test robot
2023-04-28 1:37 ` kernel test robot
2023-04-25 9:16 ` [PATCH tracing 2/3] selftests/ftrace: add test coverage for " Alan Maguire
2023-04-25 9:16 ` [PATCH tracing 3/3] tracing: document > 8 byte numeric filtering support Alan Maguire
2023-04-25 14:32 ` [PATCH tracing 0/3] tracing: support > 8 byte filter predicates Masami Hiramatsu
2023-04-25 17:15 ` Alan Maguire
2023-04-25 17:20 ` Steven Rostedt [this message]
2023-04-26 8:51 ` Alan Maguire
2023-04-26 14:08 ` Steven Rostedt
2023-04-26 14:12 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230425132028.7d16e04c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=alan.maguire@oracle.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).