From: Eduardo Valentin <evalenti@kernel.org>
To: daniel.lezcano@linaro.org, rafael@kernel.org, linux-pm@vger.kernel.org
Cc: Eduardo Valentin <eduval@amazon.com>,
Amit Kucheria <amitk@kernel.org>, Zhang Rui <rui.zhang@intel.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] thermal: core: register reboot nb
Date: Thu, 25 May 2023 14:16:54 -0700 [thread overview]
Message-ID: <20230525211655.627415-3-evalenti@kernel.org> (raw)
In-Reply-To: <20230525211655.627415-1-evalenti@kernel.org>
From: Eduardo Valentin <eduval@amazon.com>
This commit will register a reboot notifier block
callback for giving opportunity tearing down
thermal zones, e.g. remove their workqueues, and
for giving the governors the opportunity to leave
the hardware in a known safe state.
Cc: "Rafael J. Wysocki" <rafael@kernel.org> (supporter:THERMAL)
Cc: Daniel Lezcano <daniel.lezcano@linaro.org> (supporter:THERMAL)
Cc: Amit Kucheria <amitk@kernel.org> (reviewer:THERMAL)
Cc: Zhang Rui <rui.zhang@intel.com> (reviewer:THERMAL)
Cc: Jonathan Corbet <corbet@lwn.net> (maintainer:DOCUMENTATION)
Cc: linux-pm@vger.kernel.org (open list:THERMAL)
Cc: linux-doc@vger.kernel.org (open list:DOCUMENTATION)
Cc: linux-kernel@vger.kernel.org (open list)
Signed-off-by: Eduardo Valentin <eduval@amazon.com>
---
drivers/thermal/thermal_core.c | 39 ++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
index 359e7b2ff0e3..66a255fb650b 100644
--- a/drivers/thermal/thermal_core.c
+++ b/drivers/thermal/thermal_core.c
@@ -319,6 +319,12 @@ static void handle_error_temperature(struct thermal_zone_device *tz, int error)
tz->governor->check_error(tz, error);
}
+static void handle_reboot_prepare(struct thermal_zone_device *tz)
+{
+ if (tz->governor && tz->governor->reboot_prepare)
+ tz->governor->reboot_prepare(tz);
+}
+
void thermal_zone_device_critical(struct thermal_zone_device *tz)
{
/*
@@ -1508,6 +1514,30 @@ struct thermal_zone_device *thermal_zone_get_zone_by_name(const char *name)
}
EXPORT_SYMBOL_GPL(thermal_zone_get_zone_by_name);
+/* Best effort attempt to leave thermal zones at a safe state across reboots */
+static void thermal_reboot_prepare(void)
+{
+ struct thermal_zone_device *tz;
+
+ list_for_each_entry(tz, &thermal_tz_list, node) {
+ cancel_delayed_work(&tz->poll_queue);
+ handle_reboot_prepare(tz);
+ }
+}
+
+static int thermal_reboot_notify(struct notifier_block *nb,
+ unsigned long mode, void *_unused)
+{
+ switch (mode) {
+ case SYS_RESTART:
+ thermal_reboot_prepare();
+ break;
+ default:
+ break;
+ }
+ return 0;
+}
+
static int thermal_pm_notify(struct notifier_block *nb,
unsigned long mode, void *_unused)
{
@@ -1539,6 +1569,10 @@ static struct notifier_block thermal_pm_nb = {
.notifier_call = thermal_pm_notify,
};
+static struct notifier_block thermal_reboot_nb = {
+ .notifier_call = thermal_reboot_notify,
+};
+
static int __init thermal_init(void)
{
int result;
@@ -1572,6 +1606,11 @@ static int __init thermal_init(void)
pr_warn("Thermal: Can not register suspend notifier, return %d\n",
result);
+ result = register_reboot_notifier(&thermal_reboot_nb);
+ if (result)
+ pr_warn("Thermal: Can not register reboot notifier, return %d\n",
+ result);
+
return 0;
unregister_governors:
--
2.34.1
next prev parent reply other threads:[~2023-05-25 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230525211655.627415-1-evalenti@kernel.org>
2023-05-25 21:16 ` [PATCH 1/3] thermal: core: introduce governor .reboot_prepare() Eduardo Valentin
2023-05-25 21:16 ` Eduardo Valentin [this message]
2023-05-25 21:16 ` [PATCH 3/3] thermal: core: register a crash callback Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525211655.627415-3-evalenti@kernel.org \
--to=evalenti@kernel.org \
--cc=amitk@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=eduval@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).