From: Alan Huang <mmpgouride@gmail.com>
To: paulmck@kernel.org
Cc: corbet@lwn.net, rcu@vger.kernel.org, linux-doc@vger.kernel.org,
Alan Huang <mmpgouride@gmail.com>
Subject: [PATCH] docs/RCU: Add the missing rcu_read_unlock()
Date: Sat, 10 Jun 2023 04:06:08 +0000 [thread overview]
Message-ID: <20230610040608.6355-1-mmpgouride@gmail.com> (raw)
We should exit the RCU read-side critical section before re-entering.
Signed-off-by: Alan Huang <mmpgouride@gmail.com>
---
Documentation/RCU/rculist_nulls.rst | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/RCU/rculist_nulls.rst b/Documentation/RCU/rculist_nulls.rst
index 9a734bf54..4370ac864 100644
--- a/Documentation/RCU/rculist_nulls.rst
+++ b/Documentation/RCU/rculist_nulls.rst
@@ -30,6 +30,7 @@ algorithms:
obj = lockless_lookup(key);
if (obj) {
if (!try_get_ref(obj)) // might fail for free objects
+ rcu_read_unlock();
goto begin;
/*
* Because a writer could delete object, and a writer could
--
2.34.1
next reply other threads:[~2023-06-10 4:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-10 4:06 Alan Huang [this message]
2023-06-12 21:26 ` [PATCH] docs/RCU: Add the missing rcu_read_unlock() Paul E. McKenney
2023-06-13 0:59 ` Alan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610040608.6355-1-mmpgouride@gmail.com \
--to=mmpgouride@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).