From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8241EB64D7 for ; Tue, 20 Jun 2023 07:07:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230472AbjFTHHJ (ORCPT ); Tue, 20 Jun 2023 03:07:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229597AbjFTHHH (ORCPT ); Tue, 20 Jun 2023 03:07:07 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 256D510F9; Tue, 20 Jun 2023 00:07:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AEEA761028; Tue, 20 Jun 2023 07:07:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BAD73C433C0; Tue, 20 Jun 2023 07:07:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1687244822; bh=GR6mhcNPQGfkgf7foRclZExHB5KiyAu6DP74hdSupHI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YYHRqV7NGao0+/4qGNuIYHGB7c2vQTiWCmItJ4yhidm8FjqgK5mH0b1OpmvjwZHA1 pAlF3lBlSnWan838AKvkOAAqtL8/0MkeQhKPQZNpcxgm0nVgUd6n70zqNd4p8bEx1v rFikaycLUbi9MorxHDXIMgYoe1l2ruTkLLUfR4/I= Date: Tue, 20 Jun 2023 09:06:57 +0200 From: Greg KH To: Saurabh Singh Sengar Cc: Saurabh Sengar , KY Srinivasan , Haiyang Zhang , "wei.liu@kernel.org" , Dexuan Cui , "Michael Kelley (LINUX)" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-doc@vger.kernel.org" Subject: Re: [EXTERNAL] Re: [PATCH v2 1/5] uio: Add hv_vmbus_client driver Message-ID: <2023062007-coral-nicotine-856c@gregkh> References: <1686766512-2589-1-git-send-email-ssengar@linux.microsoft.com> <1686766512-2589-2-git-send-email-ssengar@linux.microsoft.com> <2023061419-probe-velocity-b276@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Tue, Jun 20, 2023 at 05:19:14AM +0000, Saurabh Singh Sengar wrote: > > And you are defining a "global" variable that can be modified by an individual > > sysfs file for ANY device bound to this driver, messing with the other device's > > ring buffer size, right? This needs to be per-device, or explain in huge detail > > here why not. > > The global variable is expected to be set by userspace per device before opening, the > particular uio device. For a particular Hyper-v device this value be same, and once > device is open the ring buffer is allocated and there won't be any impact afterwards > changing it. I can elaborate more of this in sysfs documentation. That's totally confusing, please make this per-device properly, as you will find out when you try to document it, what you are describing is unlike any other per-device interface we have. greg k-h