From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
Pavel Begunkov <asml.silence@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
leit@meta.com, Arnd Bergmann <arnd@arndb.de>,
Steve French <stfrench@microsoft.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Jiri Slaby <jirislaby@kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>,
Jason Gunthorpe <jgg@ziepe.ca>, Simon Ser <contact@emersion.fr>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:IO_URING" <io-uring@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>
Subject: Re: [PATCH] io_uring: Add io_uring command support for sockets
Date: Thu, 22 Jun 2023 10:39:48 -0700 [thread overview]
Message-ID: <20230622103948.33cbb0dd@kernel.org> (raw)
In-Reply-To: <2023062228-cloak-wish-ec12@gregkh>
On Thu, 22 Jun 2023 19:03:04 +0200 Greg Kroah-Hartman wrote:
> > Correct. For now we are just using 0xa0 and 0xa1, and eventually we
> > might need more ioctls numbers.
> >
> > I got these numbers finding a unused block and having some room for
> > expansion, as suggested by Documentation/userspace-api/ioctl/ioctl-number.rst,
> > that says:
> >
> > If you are writing a driver for a new device and need a letter, pick an
> > unused block with enough room for expansion: 32 to 256 ioctl commands.
>
> So is this the first io_uring ioctl? If so, why is this an ioctl and
> not just a "normal" io_uring call?
+1, the mixing with classic ioctl seems confusing and I'm not sure
if it buys us anything.
--
pw-bot: cr
next prev parent reply other threads:[~2023-06-22 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 23:21 [PATCH] io_uring: Add io_uring command support for sockets Breno Leitao
2023-06-22 5:20 ` Greg Kroah-Hartman
2023-06-22 15:02 ` Breno Leitao
2023-06-22 16:10 ` Greg Kroah-Hartman
2023-06-22 16:38 ` Breno Leitao
2023-06-22 17:03 ` Greg Kroah-Hartman
2023-06-22 17:39 ` Jakub Kicinski [this message]
2023-06-22 19:01 ` Breno Leitao
2023-06-22 18:57 ` Breno Leitao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230622103948.33cbb0dd@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=baolu.lu@linux.intel.com \
--cc=contact@emersion.fr \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=io-uring@vger.kernel.org \
--cc=jgg@ziepe.ca \
--cc=jirislaby@kernel.org \
--cc=leit@meta.com \
--cc=leitao@debian.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).