From: Jim Shargo <jshargo@chromium.org>
To: mairacanal@riseup.net, Daniel Vetter <daniel@ffwll.ch>,
David Airlie <airlied@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Melissa Wen <melissa.srw@gmail.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: Jim Shargo <jshargo@chromium.org>,
dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/6] Adds support for ConfigFS to VKMS!
Date: Fri, 23 Jun 2023 18:23:42 -0400 [thread overview]
Message-ID: <20230623222353.97283-1-jshargo@chromium.org> (raw)
Intro
=====
At long last, we're back!
This patchset adds basic ConfigFS support to VKMS, allowing users to
build new DRM devices with user-defined DRM objects and object
relationships by creating, writing, and symlinking files.
Usage
=====
After installing these patches, you can create a VKMS device with two
displays and a movable overlay like so (this is documented in the
patches):
$ modprobe vkms enable_overlay=1 enable_cursor=1 enable_writeback=1
$ mkdir -p /config/
$ mount -t configfs none /config
$ export DRM_PLANE_TYPE_PRIMARY=1
$ export DRM_PLANE_TYPE_CURSOR=2
$ export DRM_PLANE_TYPE_OVERLAY=0
$ mkdir /config/vkms/test
$ mkdir /config/vkms/test/planes/primary
$ echo $DRM_PLANE_TYPE_PRIMARY > /config/vkms/test/planes/primary/type
$ mkdir /config/vkms/test/planes/other_primary
$ echo $DRM_PLANE_TYPE_PRIMARY > /config/vkms/test/planes/other_primary/type
$ mkdir /config/vkms/test/planes/cursor
$ echo $DRM_PLANE_TYPE_CURSOR > /config/vkms/test/planes/cursor/type
$ mkdir /config/vkms/test/planes/overlay
$ echo $DRM_PLANE_TYPE_OVERLAY > /config/vkms/test/planes/overlay/type
$ mkdir /config/vkms/test/crtcs/crtc
$ mkdir /config/vkms/test/crtcs/crtc_other
$ mkdir /config/vkms/test/encoders/encoder
$ mkdir /config/vkms/test/connectors/connector
$ ln -s /config/vkms/test/encoders/encoder /config/vkms/test/connectors/connector/possible_encoders
$ ln -s /config/vkms/test/crtcs/crtc /config/vkms/test/encoders/encoder/possible_crtcs/
$ ln -s /config/vkms/test/crtcs/crtc /config/vkms/test/planes/primary/possible_crtcs/
$ ln -s /config/vkms/test/crtcs/crtc /config/vkms/test/planes/cursor/possible_crtcs/
$ ln -s /config/vkms/test/crtcs/crtc /config/vkms/test/planes/overlay/possible_crtcs/
$ ln -s /config/vkms/test/crtcs/crtc_other /config/vkms/test/planes/overlay/possible_crtcs/
$ ln -s /config/vkms/test/crtcs/crtc_other /config/vkms/test/planes/other_primary/possible_crtcs/
$ echo 1 > /config/vkms/test/enabled
Changes within core VKMS
========================
This introduces a few important changes to the overall structure of
VKMS:
- Devices are now memory managed!
- Support for multiple CRTCs and other objects has been added
Since v1
========
- Added DRMM memory management to automatically clean up resources
- Added a param to disable the default device
- Renamed "cards" to "devices" to improve legibility
- Added a lock for the configfs setup handler
- Moved all the new docs into the relevant .c file
- Addressed as many of sean@poorly.run as possible
Testing
=======
- New IGT tests (see
gitlab.freedesktop.org/jshargo/igt-gpu-tools/-/merge_requests/1)
- Existing IGT tests (excluding .*suspend.*, including .*kms_flip.*
.*kms_writeback.* .*kms_cursor_crc.*, .*kms_plane.*)
Outro
=====
I'm excited to share these changes, it's my still my first kernel patch
and I've been putting a lot of love into these.
Jim Shargo (6):
drm/vkms: Back VKMS with DRM memory management instead of static
objects
drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device
drm/vkms: Provide platform data when creating VKMS devices
drm/vkms: Add ConfigFS scaffolding to VKMS
drm/vkms: Support enabling ConfigFS devices
drm/vkms: Add a module param to enable/disable the default device
Documentation/gpu/vkms.rst | 17 +-
drivers/gpu/drm/Kconfig | 1 +
drivers/gpu/drm/vkms/Makefile | 1 +
drivers/gpu/drm/vkms/vkms_composer.c | 28 +-
drivers/gpu/drm/vkms/vkms_configfs.c | 657 ++++++++++++++++++++++++++
drivers/gpu/drm/vkms/vkms_crtc.c | 97 ++--
drivers/gpu/drm/vkms/vkms_drv.c | 208 +++++---
drivers/gpu/drm/vkms/vkms_drv.h | 166 +++++--
drivers/gpu/drm/vkms/vkms_output.c | 299 ++++++++++--
drivers/gpu/drm/vkms/vkms_plane.c | 44 +-
drivers/gpu/drm/vkms/vkms_writeback.c | 26 +-
11 files changed, 1312 insertions(+), 232 deletions(-)
create mode 100644 drivers/gpu/drm/vkms/vkms_configfs.c
--
2.41.0.162.gfafddb0af9-goog
next reply other threads:[~2023-06-23 22:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 22:23 Jim Shargo [this message]
2023-06-23 22:23 ` [PATCH v2 1/6] drm/vkms: Back VKMS with DRM memory management instead of static objects Jim Shargo
2023-06-25 17:40 ` Maira Canal
2023-06-23 22:23 ` [PATCH v2 2/6] drm/vkms: Support multiple DRM objects (crtcs, etc.) per VKMS device Jim Shargo
2023-06-25 17:57 ` Maira Canal
2023-08-15 11:29 ` Marius Vlad
2023-08-18 3:36 ` Brandon Pollack
2023-08-18 5:26 ` Brandon Ross Pollack
2023-06-23 22:23 ` [PATCH v2 3/6] drm/vkms: Provide platform data when creating VKMS devices Jim Shargo
2023-06-23 22:23 ` [PATCH v2 4/6] drm/vkms: Add ConfigFS scaffolding to VKMS Jim Shargo
2023-06-25 18:19 ` Maira Canal
2023-06-28 2:00 ` kernel test robot
2023-06-23 22:23 ` [PATCH v2 5/6] drm/vkms: Support enabling ConfigFS devices Jim Shargo
2023-08-15 14:01 ` Marius Vlad
2023-08-18 5:24 ` Brandon Ross Pollack
2023-08-18 6:54 ` Marius Vlad
2023-06-23 22:23 ` [PATCH v2 6/6] drm/vkms: Add a module param to enable/disable the default device Jim Shargo
2023-06-25 18:04 ` Maira Canal
2023-08-18 5:39 ` Brandon Ross Pollack
2023-08-08 2:42 ` Brandon Pollack
2023-08-08 2:42 ` [PATCH] Initial backport of vkms changes from 6.4, including jshargo and brpols configs changes Brandon Pollack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230623222353.97283-1-jshargo@chromium.org \
--to=jshargo@chromium.org \
--cc=airlied@gmail.com \
--cc=corbet@lwn.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mairacanal@riseup.net \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).