From: Alan Huang <mmpgouride@gmail.com>
To: paulmck@kernel.org, frederic@kernel.org,
quic_neeraju@quicinc.com, joel@joelfernandes.org,
josh@joshtriplett.org, boqun.feng@gmail.com, corbet@lwn.net
Cc: rcu@vger.kernel.org, linux-doc@vger.kernel.org,
Alan Huang <mmpgouride@gmail.com>
Subject: [PATCH 1/2] rcu: Use WRITE_ONCE() for assignments to ->next for rculist_nulls
Date: Thu, 6 Jul 2023 10:28:48 +0000 [thread overview]
Message-ID: <20230706102849.437687-2-mmpgouride@gmail.com> (raw)
In-Reply-To: <20230706102849.437687-1-mmpgouride@gmail.com>
When the objects managed by rculist_nulls are allocated with
SLAB_TYPESAFE_BY_RCU, readers may still hold references to this
object that is being added, which means the modification of ->next
is visible to readers. So, this patch uses WRITE_ONCE() for assignments
to ->next.
Signed-off-by: Alan Huang <mmpgouride@gmail.com>
---
include/linux/rculist_nulls.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/rculist_nulls.h b/include/linux/rculist_nulls.h
index ba4c00dd8005..89186c499dd4 100644
--- a/include/linux/rculist_nulls.h
+++ b/include/linux/rculist_nulls.h
@@ -101,7 +101,7 @@ static inline void hlist_nulls_add_head_rcu(struct hlist_nulls_node *n,
{
struct hlist_nulls_node *first = h->first;
- n->next = first;
+ WRITE_ONCE(n->next, first);
WRITE_ONCE(n->pprev, &h->first);
rcu_assign_pointer(hlist_nulls_first_rcu(h), n);
if (!is_a_nulls(first))
@@ -137,7 +137,7 @@ static inline void hlist_nulls_add_tail_rcu(struct hlist_nulls_node *n,
last = i;
if (last) {
- n->next = last->next;
+ WRITE_ONCE(n->next, last->next);
n->pprev = &last->next;
rcu_assign_pointer(hlist_nulls_next_rcu(last), n);
} else {
--
2.34.1
next prev parent reply other threads:[~2023-07-06 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 10:28 [PATCH 0/2] rcu: Fix rculist_nulls and doc Alan Huang
2023-07-06 10:28 ` Alan Huang [this message]
2023-07-10 19:08 ` [PATCH 1/2] rcu: Use WRITE_ONCE() for assignments to ->next for rculist_nulls Paul E. McKenney
2023-07-10 20:01 ` Joel Fernandes
2023-07-10 20:30 ` Paul E. McKenney
2023-07-11 14:56 ` Alan Huang
2023-07-11 16:45 ` Paul E. McKenney
2023-07-11 14:51 ` Alan Huang
2023-07-06 10:28 ` [PATCH 2/2] docs/RCU: Bring back smp_wmb() Alan Huang
2023-07-10 19:11 ` Paul E. McKenney
2023-07-11 14:50 ` Alan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230706102849.437687-2-mmpgouride@gmail.com \
--to=mmpgouride@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=corbet@lwn.net \
--cc=frederic@kernel.org \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-doc@vger.kernel.org \
--cc=paulmck@kernel.org \
--cc=quic_neeraju@quicinc.com \
--cc=rcu@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).